Skip to content

Fix failing GitHub Actions "cmake" job on Windows#123

Open
DDvO wants to merge 14 commits into
masterfrom
fix-Debian-packaging
Open

Fix failing GitHub Actions "cmake" job on Windows#123
DDvO wants to merge 14 commits into
masterfrom
fix-Debian-packaging

Conversation

@DDvO

@DDvO DDvO commented Jun 15, 2026

Copy link
Copy Markdown
Member

The cmake CI job started failing on June 12, 2026 when windows-latest was updated to the windows-2025-vs2026 runner image (Visual Studio 2026), which no longer includes Visual Studio 2022 (VS 17).

Root Cause

The workflow hardcoded -G "Visual Studio 17 2022" in both cmake invocations. When the windows-latest runner image changed to one that ships Visual Studio 2026 instead of VS 2022, cmake could no longer find any matching Visual Studio instance and failed at the project() call.

Fix

Removed the hardcoded -G "Visual Studio 17 2022" generator flag from both cmake steps in .github/workflows/windows.yml, keeping only -A x64 for the target architecture. CMake will now auto-detect the installed Visual Studio version, making the workflow resilient to future runner image updates.

@DDvO DDvO added bug Something isn't working enhancement New feature or request labels Jun 15, 2026
@DDvO DDvO force-pushed the fix-Debian-packaging branch from b99b703 to d1a4344 Compare June 15, 2026 15:14
Copilot AI changed the title Fix Debian packaging Fix failing GitHub Actions "cmake" job on Windows Jun 15, 2026
Copilot finished work on behalf of DDvO June 15, 2026 15:28
@DDvO DDvO force-pushed the fix-Debian-packaging branch from 0b9ad18 to d5b4fc0 Compare June 15, 2026 15:30
@DDvO DDvO force-pushed the fix-Debian-packaging branch from d5b4fc0 to f99da80 Compare June 15, 2026 15:43
@DDvO DDvO marked this pull request as ready for review June 15, 2026 15:50
Copilot finished work on behalf of DDvO June 15, 2026 15:56
@DDvO DDvO force-pushed the fix-Debian-packaging branch from 9fa01b3 to 811f101 Compare June 17, 2026 12:55
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants