Fix for "IllegalStateException when OTEL_SDK_DISABLED is set to true" - #2993
Merged
Conversation
robsunday
changed the title
breedx-splk
reviewed
Aug 10, 2026
breedx-splk
left a comment
breedx-splk
left a comment
Contributor
There was a problem hiding this comment.
Since there have been additional changes to the snapshot profiler supervisor code since the release, it's quite unclear where the actual fix is in this changeset. There's also no hints from any tests, so I can't tell.
Comment on lines
+22
to
29
| public interface SnapshotProfilingSpanProcessor extends SpanProcessor { | ||
| OptionalConfigurableSupplier<SnapshotProfilingSpanProcessor> SUPPLIER = | ||
| new OptionalConfigurableSupplier<>(new NoopSnapshotProfilingSpanProcessor()); | ||
|
|
||
| public void setEnabled(boolean enabled) { | ||
| this.enabled = enabled; | ||
| } | ||
| void setEnabled(boolean enabled); | ||
|
|
||
| public boolean isEnabled() { | ||
| return enabled; | ||
| } | ||
| boolean isEnabled(); | ||
| } |
Contributor
There was a problem hiding this comment.
Certainly doesn't have to be in this PR, but there's room for this to be a more generic "span processor which can be enabled/disabled". Maybe EnableableSpanProcessor but that doesn't really flow off the tongue....maybe ToggleableSpanProcessor but I dunno. This could also be an upstream addition perhaps. Just thinking out loud.
breedx-splk
reviewed
Aug 10, 2026
Comment on lines
+23
to
+24
| OptionalConfigurableSupplier<SnapshotProfilingSpanProcessor> SUPPLIER = | ||
| new OptionalConfigurableSupplier<>(new NoopSnapshotProfilingSpanProcessor()); |
Contributor
There was a problem hiding this comment.
oh this is the actual fix.
breedx-splk
approved these changes
Aug 10, 2026
laurit
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2989