TT-5727 prevent messages from integration from showing if closed#354
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent Paratext integration UI side-effects (notably snackbar/toast messages) from appearing after the Integration dialog has been closed, by ensuring the integration panel is unmounted when the dialog is not open and by guarding message emission against unmounted state.
Changes:
- Conditionally mount/unmount the
IntegrationTabinsideBigDialogso it is only rendered while the dialog is open. - Add
useMountedchecks inIntegrationPanelto avoid emitting messages after the component has unmounted, and reset Paratext-related Redux state on unmount. - Minor formatting adjustment to a
logErrorcall for readability/consistency.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/renderer/src/control/ProjButtons.tsx | Only render IntegrationTab while the Integration dialog is open (prevents late UI messages after close). |
| src/renderer/src/components/Team/ProjectCard.tsx | Same conditional mounting of IntegrationTab for the Team Project card integration dialog. |
| src/renderer/src/components/MediaRecord.tsx | Formatting-only change to logError call. |
| src/renderer/src/components/Integration.tsx | Add useMounted gating for message display and reset Paratext slice state on unmount to prevent stale/status messages after close. |
gtryus
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.