Refine segment view#98
Merged
Merged
Conversation
|
Note Reviews pausedUse the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughRefactors navigation to a provider with cross-book fade, implements scroll-window + recenter/snap lifecycle, centralizes phrase-strip hooks, adds a chapter-label-in-verse setting with UI and wiring, and expands tests and test infrastructure. ChangesInterlinearizer Navigation & Windowing Refactor
Sequence DiagramsequenceDiagram
participant WebView as Host WebView
participant Loader as InterlinearizerLoader
participant Nav as InterlinearNavProvider
participant Inter as Interlinearizer
participant Window as useSegmentWindow
participant Recenter as useRecenterSnap
WebView->>Loader: useWebViewScrollGroupScrRef()
Loader->>Nav: wrap subtree with provider
Nav->>Inter: useInterlinearNav() => rawScrRef/scrRef/navigate()
Inter->>Window: useSegmentWindow(scrRef, consumeInternalNav)
alt External cross-book navigation
Inter->>Nav: navigate(ref, 'external')
Nav->>Inter: fadePhase='out'
Inter->>Recenter: markRecenterStarted()
Recenter->>Window: snapActiveToTop()
Window->>Inter: rebuild windowSegments
Recenter->>Inter: beginRecenterSettle() -> onSettled
Nav->>Inter: fadePhase='in' then 'idle' after RECENTER_FADE_MS
else Internal same-book navigation
Inter->>Nav: navigate(ref, 'internal')
Window->>Inter: update display refs immediately (no fade)
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Closed
alex-rawlings-yyc
force-pushed
the
refine-segment-view
branch
4 times, most recently
from
a18e2c8 to
c78343e
Compare
…fade/realignment timing issues, add chapter markers and associated setting
alex-rawlings-yyc
force-pushed
the
refine-segment-view
branch
from
a00112f to
dbd2d6b
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
…rse-0 dead code (#103) Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
imnasnainaec
approved these changes
Jun 12, 2026
imnasnainaec
left a comment
imnasnainaec
left a comment
Contributor
There was a problem hiding this comment.
@imnasnainaec partially reviewed 12 files.
Reviewable status: 12 of 38 files reviewed, all discussions resolved (waiting on alex-rawlings-yyc).
alex-rawlings-yyc
left a comment
alex-rawlings-yyc
left a comment
Contributor
Author
There was a problem hiding this comment.
@alex-rawlings-yyc reviewed 38 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on alex-rawlings-yyc).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is
Summary by CodeRabbit
New Features
Improvements