Fix crash on corrupt Windows language installation#1507
Merged
Conversation
WritingSystemFromWindowsLocaleProvider.GetLanguageAndKeyboardCombinations accessed InputLanguage.LayoutName unguarded, which can throw a NullReferenceException from System.Windows.Forms when a user has a corrupt Windows language installation. Read the layout name inside a try/catch and skip the offending language instead of crashing the whole enumeration. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
hahn-kev
approved these changes
Jun 18, 2026
hahn-kev
left a comment
hahn-kev
left a comment
Contributor
There was a problem hiding this comment.
looks good to me, though I don't know the code well and I didn't test it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #761
WritingSystemFromWindowsLocaleProvider.GetLanguageAndKeyboardCombinations accessed InputLanguage.LayoutName unguarded, which can throw a NullReferenceException from System.Windows.Forms when a user has a corrupt Windows language installation. Read the layout name inside a try/catch and skip the offending language instead of crashing the whole enumeration.
Devin review: https://app.devin.ai/review/sillsdev/libpalaso/pull/1507
This change is