Fix date in generated PR commit message#1508
Merged
Merged
Conversation
The $(date ...) substitution was inside a YAML commit-message value passed to peter-evans/create-pull-request, so it was emitted literally. Compute the date in a separate step and reference its output. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
hahn-kev
approved these changes
Jun 18, 2026
hahn-kev
left a comment
hahn-kev
left a comment
Contributor
There was a problem hiding this comment.
this looks good, is it possible to do a dry run to ensure this works as expected?
Contributor
Author
@hahn-kev Good idea. I just did the workflow dispatch from this branch and it worked! See the commit message here: 8108581 Also, since we're due for an update to those language files--WSTech had a new release last week--I'm leaving open the pr it generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1448
The $(date ...) substitution was inside a YAML commit-message value passed to peter-evans/create-pull-request, so it was emitted literally. Compute the date in a separate step and reference its output.
Devin review: https://app.devin.ai/review/sillsdev/libpalaso/pull/1508
This change is