Remove requirement for intensity map#30
Open
JBorrow wants to merge 3 commits into
Open
Conversation
axf295
approved these changes
May 20, 2026
Contributor
axf295
left a comment
axf295
left a comment
There was a problem hiding this comment.
Seems good. is this coverage not calculated anywhere in mapcat? i.e. coverage_map should be implemented in those locations
(I had thought there was tiling information or something)
Member
Author
|
Indeed we should refactor those other cases that just use map blindly... |
Contributor
copilot -- do! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the requirement for the intensity map and adds a new property to
DepthOneMapTable:which is a path to a map that can be used for coverage checking.