Migrate DOM-classes to PHP 8.4's new DOM-API#89
Open
tvdijen wants to merge 31 commits into
Open
Conversation
Fix use of incorrect property
…oume Canonicalize XML assertions and harden DOM parsing/namespace handling
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release-3.x #89 +/- ##
=================================================
- Coverage 91.78% 91.31% -0.48%
- Complexity 948 968 +20
=================================================
Files 219 218 -1
Lines 3432 3488 +56
=================================================
+ Hits 3150 3185 +35
- Misses 282 303 +21 🚀 New features to boost your workflow:
|
tvdijen
force-pushed
the
feature/dom-migration-php84
branch
from
df61863 to
68e205e
Compare
tvdijen
force-pushed
the
feature/dom-migration-php84
branch
from
23415d6 to
9882e35
Compare
tvdijen
force-pushed
the
feature/dom-migration-php84
branch
from
a238f04 to
cf8d29d
Compare
…or across modules. Fix bugs.
…oume2 feature/dom-migration-php84-ioigoume2
…e when asserting xml strings during testing. revert:Insignificant Whitespace removal
…oume3 feature/dom-migration-php84-ioigoume3
tvdijen
commented
Jun 8, 2026
| )); | ||
| } | ||
|
|
||
| // 2) New validation (temporarily disabled) |
tvdijen
force-pushed
the
feature/dom-migration-php84
branch
2 times, most recently
from
0b2052d to
0d12417
Compare
tvdijen
force-pushed
the
release-3.x
branch
3 times, most recently
from
8275142 to
25190f6
Compare
tvdijen
force-pushed
the
feature/dom-migration-php84
branch
from
df0a7be to
8d40ff6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #87