Conversation
|
GH Workflow linter is different than standalone linter. Fixed errors and trying again. |
|
Thanks for making an Awesome list! 🙌 It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome. |
|
I didn’t!
Nichole Charterina
…________________________________
From: Sindre Sorhus ***@***.***>
Sent: Thursday, October 23, 2025 1:07:34 AM
To: sindresorhus/awesome ***@***.***>
Cc: Subscribed ***@***.***>
Subject: Re: [sindresorhus/awesome] Awesome 3D Drawing (PR #3711)
[https://avatars.githubusercontent.com/u/170270?s=20&v=4]sindresorhus left a comment (sindresorhus/awesome#3711)<#3711 (comment)>
Thanks for making an Awesome list! 🙌
It looks like you didn't read the guidelines<https://github.com/sindresorhus/awesome/blob/master/pull_request_template.md> closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome.
—
Reply to this email directly, view it on GitHub<#3711 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AZ4IVLU5HLEB22QQHJKAFD33ZBPBNAVCNFSM6AAAAACJ6ZBZHCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTIMZVGA4TGNJSGE>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
|
Unicorn--reread guidelines, reviewed error logs from two PRs, ready for review. |
This requirement is not fulfilled. |
|
Done |
|
I didn’t!
Nichole Charterina
…________________________________
From: Sindre Sorhus ***@***.***>
Sent: Thursday, October 23, 2025 1:07:34 AM
To: sindresorhus/awesome ***@***.***>
Cc: Subscribed ***@***.***>
Subject: Re: [sindresorhus/awesome] Awesome 3D Drawing (PR #3711)
[https://avatars.githubusercontent.com/u/170270?s=20&v=4]sindresorhus left a comment (sindresorhus/awesome#3711)<#3711 (comment)>
Thanks for making an Awesome list! 🙌
It looks like you didn't read the guidelines<https://github.com/sindresorhus/awesome/blob/master/pull_request_template.md> closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome.
—
Reply to this email directly, view it on GitHub<#3711 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AZ4IVLU5HLEB22QQHJKAFD33ZBPBNAVCNFSM6AAAAACJ6ZBZHCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTIMZVGA4TGNJSGE>.
You are receiving this because you are subscribed to this thread.
|
|
Hey! This looks like an interesting niche topic, but you need to complete the checklist before this can be reviewed. Key things I noticed: ❌ You haven't checked any of the requirement boxes - Please go through each one carefully Please complete these requirements and check all the boxes that apply. Most importantly, review 2 other PRs first - that's a hard requirement for all submissions. Good luck! |
|
@tysoncung I constructively reviewed two PRs referring to error logs. Re: checkboxes, are those functional? I thought they were decorative. Re: unicorn, did that have to be in its own comment? I will say it again. |
|
unicorn |
|
Great niche topic that's increasingly relevant. The list covers academic papers, tools, and practical applications well. The description could be slightly clearer for people unfamiliar with the field. Current: "3D drawing and painting with 6 degrees of freedom." Maybe: "Creating 3D art and animations using motion-tracked controllers in virtual/augmented reality." |
|
I like it! Revised the blurb. |
|
Synced latest version to remove merge conflicts. |
|
Can l have a working configuration
…On Thu, 20 Nov 2025, 08:42 Nick Fox-Gieg, ***@***.***> wrote:
*n1ckfg* left a comment (sindresorhus/awesome#3711)
<#3711 (comment)>
Synced latest version to remove merge conflicts.
—
Reply to this email directly, view it on GitHub
<#3711 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BZI2BBBCQ3YCYV4IBY2MOED35VPE7AVCNFSM6AAAAACJ6ZBZHCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTKNJWGE4DCNZXGI>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
Checked the list and it looks solid. Here's what I found: Compliance ✓
Quality observations:
Minor suggestion: Otherwise this is ready to go from what I can see. The content is well curated and follows all the guidelines. |
|
Seems like all the requirements are met--how do we get to final approval? |
|
Nice list! Reviewed the awesome-3D-drawing repo - it's well-curated with good coverage of VR/XR drawing tools and research papers. Observations:
This looks ready for merge. Good work on curating this specialized topic! |
|
Not sure what's left to do for final approval--if anybody has any suggestions, please let me know! |
|
Synced and reopened PR. |
|
Still waiting on final approval |
|
@sindresorhus @davisonio Hey, have I left anything undone for final approval on this? |
|
[Insert URL to the list here]
https://github.com/n1ckfg/awesome-3D-drawing#readme
[Explain what this list is about and why it should be included here]
3D drawing papers and related resources--the overlap of XR work that uses 6DoF controllers, and ML work that processes and renders frame-by-frame volumetric representations. This is a niche field but one of increasing interest to mainstream animation and VFX production (covers techniques used in the "Spiderverse" films, for example). 100% pass on the linter tool.
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request
Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration. Just commenting “looks good” or simply marking the pull request as approved does not count! You have to actually point out mistakes or improvement suggestions. Comments pointing out lint violation are allowed, but does not count as a review.
Add Name of List. It should not contain the wordAwesome.Add SwiftAdd Software ArchitectureUpdate readme.mdAdd Awesome SwiftAdd swiftadd SwiftAdding SwiftAdded Swift- [iOS](…) - Mobile operating system for Apple phones and tablets.- [Framer](…) - Prototyping interactive UI designs.- [iOS](…) - Resources and tools for iOS development.- [Framer](…)- [Framer](…) - prototyping interactive UI designs#readme.- [Software Architecture](https://github.com/simskij/awesome-software-architecture#readme) - The discipline of designing and building software.Requirements for your Awesome list
That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
awesome-linton your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.main, notmaster.Mobile operating system for Apple phones and tablets.Prototyping interactive UI designs.Resources and tools for iOS development.Awesome Framer packages and tools.If you have not put in considerable effort into your list, your pull request will be immediately closed.
awesome-name-of-list.awesome-swiftawesome-web-typographyawesome-SwiftAwesomeWebTypography# Awesome Name of List.# Awesome Swift# Awesome Web Typography# awesome-swift# AwesomeSwiftawesome-list&awesomeas GitHub topics. I encourage you to add more relevant topics.Awesome Xand a logo withAwesome X. You can put the header image in a#(Markdown header) or<h1>.Contents, notTable of Contents.ContributingorFootnotessections.https://github.com/<user>/<repo>/community/license/new?branch=main&template=cc0-1.0(replace<user>and<repo>accordingly).licenseorLICENSEin the repo root with the license text.Licencesection to the readme. GitHub already shows the license name and link to the full text at the top of the repo.unicorn.contributing.md. The casing is up to you.Contributing, positioned at the top or bottom of the main content.Footnotessection at the bottom of the readme. The section should not be present in the Table of Contents.Example:
- [AVA](…) - JavaScript test runner.Node.js, notNodeJSornode.js.You can still use a CI for linting, but the badge has no value in the readme.
Inspired by awesome-fooorInspired by the Awesome projectkinda link at the top of the readme. The Awesome badge is enough.Go to the top and read it again.