Conversation
|
Thanks for making an Awesome list! 🙌 It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome. |
|
@reed-soul It looks like most of the linter errors are just using * for bullets instead of the preferred - ...replacing all those and rerunning should provide a clearer picture of what needs to be fixed. |
autogame-17
left a comment
There was a problem hiding this comment.
I reviewed the list at https://github.com/reed-soul/awesome-cesium and found a few issues that need attention:
-
Default branch is
master, notmain. The guidelines require the default branch to be namedmain. See: https://github.com/sindresorhus/awesome/blob/main/pull_request_template.md (section: "The default branch should be named main, not master"). -
License is MIT. The guidelines state: "We strongly recommend the CC0 license, but any Creative Commons license will work. A code license like MIT, BSD, Apache, GPL, etc, is not acceptable." You need to change the license to CC0 or another Creative Commons license.
-
Entry placement. The entry is inserted between "Tiny JS" and "Frontend GIS", but the guidelines say "Your entry should be added at the bottom of the appropriate category." It should go after the last entry in the Front-End Development section (after "WebAssembly").
These need to be fixed before the list can be accepted.
|
Thanks for the review @autogame-17! All three issues have been fixed:
|
|
@reed-soul I encourage you to carefully read through the guidelines again. You're still missing a few steps which serve as evidence you did not go through and address them all yet. |
|
Reviewing per the submission requirements: Issues found in the list (https://github.com/reed-soul/awesome-cesium):
Addressing these would bring the list into full compliance. |
JinyangWang27
left a comment
There was a problem hiding this comment.
Great addition! Cesium is a solid choice for the list.
What I like:
- Clear, focused scope
- Good description that explains what Cesium does
- Links appear to be active and relevant
One small suggestion: the description could mention the primary use cases (geospatial visualization, 3D globes, etc.) to help users immediately understand its value.
LGTM overall!
JinyangWang27
left a comment
There was a problem hiding this comment.
Solid addition! Cesium is definitely worthy of inclusion.
What works well:
- Clear description explaining what CesiumJS does (3D globes/maps with geospatial streaming)
- Good coverage: frameworks, tools, Unity/Unreal/Godot integrations, AI ecosystem
- 3D Gaussian Splatting mention shows you're tracking emerging tech
- Repo has proper structure with CC-BY-4.0 license and awesome-lint
Minor suggestion: The description mentions aerospace, defense, smart cities, digital twins as use cases — consider including one concrete example or screenshot in your list's README to showcase Cesium's visual capabilities.
Thanks for reviewing 4 other PRs first. Great community participation! LGTM
|
Review of awesome-cesium:
|
|
The Cesium ecosystem is a reasonable topic for this registry -- it is a well-established open-source 3D geospatial library with real adoption in aerospace, defense, and digital twins. The list has good coverage of the ecosystem including game engine integrations, data processing tools, and emerging AI integration. A few issues to address:
The content itself is solid and covers a real niche well. Fixing these formatting and guideline issues would make this a strong submission. |
|
your description blockquote (A curated list of awesome Cesium libraries, resources and other shiny things) is the phrasing the PR template calls out as wrong. the CesiumJS paragraph right below it is already fine, just promote that one up the Quick Start heading has an emoji in it, awesome-lint will fail on that also the Language switcher sitting between the description and the TOC feels off. bottom of the readme or footnotes would be cleaner but overall, looks great. thanks for your support. |
| - [Frontend GIS](https://github.com/joewdavies/awesome-frontend-gis#readme) - Geographic Information Systems (GIS) for web browsers. | ||
| - [WebGPU](https://github.com/mikbry/awesome-webgpu#readme) - JavaScript API for rendering and compute on GPUs. | ||
| - [WebAssembly](https://github.com/idematos/awesome-webassembly#readme) - A portable binary format for running code efficiently across platforms. | ||
| - [Cesium](https://github.com/reed-soul/awesome-cesium#readme) - Open-source JavaScript library for 3D globes and maps with geospatial data streaming. |
There was a problem hiding this comment.
description here is just the repo tagline. cesium deserves something more specific, like 3D geospatial JS library for streaming globes and planet-scale terrain
https://github.com/reed-soul/awesome-cesium#readme
Open-source JavaScript library for 3D globes and maps with geospatial data streaming. CesiumJS is the leading open-source 3D geospatial library, used in aerospace, defense, smart cities, and digital twins. This list covers frameworks, tools, game engine integrations (Unity, Unreal, Godot), AI ecosystem, and emerging technologies like 3D Gaussian Splatting.
Reviewed pull requests
I reviewed the following open PRs and left comments: