Rename Core E2E Tests -> CCIP v1.6 E2E Tests#22178
Open
Conversation
product-security-plaid-production
Bot
requested review from
ChrisAmora and
chainchad
Contributor
|
👋 kalverra, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
Contributor
There was a problem hiding this comment.
Pull request overview
Risk Rating: MEDIUM
Renames the “Core” E2E test job naming/triggering to reflect that this suite is actually CCIP v1.6 E2E, and removes now-unused workflow sections/jobs in the integration test pipeline.
Changes:
- Renames the Core E2E workflow setup/job to CCIP v1.6 E2E and updates most related trigger strings.
- Removes the separate CCIP E2E setup/job block and other disabled/dead workflow sections.
- Updates
.github/e2e-tests.ymltrigger names to CCIP v1.6 and removes legacy CCIP push triggers.
Scrupulous human review needed:
- The push-event trigger wiring between
.github/workflows/integration-tests.ymland.github/e2e-tests.yml(risk of push runs selecting no tests). - The result-check / gating behavior in
check-e2e-test-resultsafter collapsing suites (ensure this matches intended required vs optional behavior).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| .github/workflows/integration-tests.yml | Renames core E2E job to CCIP v1.6, removes CCIP E2E job, updates dependencies and result handling. |
| .github/e2e-tests.yml | Renames matrix triggers to CCIP v1.6 and removes legacy CCIP push triggers. |
Contributor
|
✅ No conflicts with other open PRs targeting |
skudasov
previously approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Core" is no longer accurate identifier for these tests, as they're all CCIP v.16 tests. Also removes some dead code.