fix: job deletion propagation policy

[gilbsgilbs]

The previous way of setting the propagation policy had no effect. As a result, child resources such as pods (among others) would not be properly destroyed.

see kubernetes-client/python#234

Summary by CodeRabbit

• Bug Fixes
  • Simplified job-deletion behavior to rely on Kubernetes for background cleanup, improving reliability of resource removal.
  • Maintains existing error handling (continues to ignore already-missing jobs) so external error responses remain unchanged.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

Updated safe_delete_job to remove explicit pod deletion and construct a V1DeleteOptions body with propagation_policy="Background", then call delete_namespaced_job passing only (jobid, namespace, body); 404 ApiException behavior remains unchanged.

Changes

Cohort / File(s)	Summary
Kubernetes job deletion logic snakemake_executor_plugin_kubernetes/__init__.py	Removed manual pod enumeration and deletion; changed V1DeleteOptions to use propagation_policy="Background" in the delete body; adjusted delete_namespaced_job call to omit the propagation_policy parameter and pass only (jobid, namespace, body); preserved existing 404-ignore ApiException handling.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

• Areas requiring attention:
  • Confirm that propagation_policy="Background" in the delete options body is accepted by the Kubernetes client and API server in this usage pattern
  • Verify that background propagation results in expected asynchronous cleanup of associated pods and does not leave orphaned resources in practice
  • Ensure the 404 ApiException handling still triggers correctly with the revised delete request structure

Possibly related PRs

• fix: delete k8s jobs after failure (important in setups where the system attaches sidecar pods, which can otherwise remain after failure) #49: Conflicting approach to pod cleanup in safe_delete_job—this PR removes manual pod deletion, while PR #49 explicitly lists and deletes pods before job deletion.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The pull request title 'fix: job deletion propagation policy' clearly and concisely identifies the main change: adjusting how the Kubernetes job deletion propagation policy is applied to ensure proper cleanup of child resources.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}