Skip to content

[iOS] Remove a stale TODO in State.ts and the unused constants export #4457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
m-bert merged 2 commits into from
Aug 20, 2026
+0 −25
Merged

[iOS] Remove a stale TODO in State.ts and the unused constants export #4457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8963815
Remove stale todo
m-bert Aug 20, 2026
11ee4aa
Remove unused exports
m-bert Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 0 additions & 23 deletions packages/react-native-gesture-handler/apple/RNGestureHandlerModule.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
#import "RNGHRuntimeDecorator.h"

#import "RNGestureHandler.h"
#import "RNGestureHandlerDirection.h"
#import "RNGestureHandlerState.h"

#import "RNGestureHandlerButton.h"
Expand Down Expand Up @@ -278,28 +277,6 @@ - (void)addOperationBlock:(GestureHandlerOperation)operation
return @[ @"onGestureHandlerEvent", @"onGestureHandlerStateChange" ];
}

#pragma mark Module Constants

- (NSDictionary *)constantsToExport
{
return @{
@"State" : @{
@"UNDETERMINED" : @(RNGestureHandlerStateUndetermined),
@"BEGAN" : @(RNGestureHandlerStateBegan),
@"ACTIVE" : @(RNGestureHandlerStateActive),
@"CANCELLED" : @(RNGestureHandlerStateCancelled),
@"FAILED" : @(RNGestureHandlerStateFailed),
@"END" : @(RNGestureHandlerStateEnd)
},
@"Direction" : @{
@"RIGHT" : @(RNGestureHandlerDirectionRight),
@"LEFT" : @(RNGestureHandlerDirectionLeft),
@"UP" : @(RNGestureHandlerDirectionUp),
@"DOWN" : @(RNGestureHandlerDirectionDown)
}
};
Comment on lines -285 to -300

@j-piasecki j-piasecki Aug 20, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Android module didn't export it?

@m-bert m-bert Aug 20, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It did, until you removed it 😄

}

- (std::shared_ptr<facebook::react::TurboModule>)getTurboModule:
(const facebook::react::ObjCTurboModule::InitParams &)params
{
Expand Down
2 changes: 0 additions & 2 deletions packages/react-native-gesture-handler/src/State.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
// TODO use State from RNModule

export const State = {
UNDETERMINED: 0,
FAILED: 1,
Expand Down
Loading