Refactor: Update method names and add PEP 257 docstrings#22
Open
Aryan-Shastri wants to merge 2 commits into
Open
Refactor: Update method names and add PEP 257 docstrings#22Aryan-Shastri wants to merge 2 commits into
Aryan-Shastri wants to merge 2 commits into
Conversation
Contributor
|
Hey @Aryan-Shastri, thanks for contributing! I'd like to see more than just a few methods changed by this PR. Hopefully, a PR addressing #20 would completely resolve that issue, and yours is helping only in part. If you'd like us to merge your PR, I ask that you continue making changes like the ones that you've already made. |
Author
|
Thanks for the feedback! You are absolutely right. I will dive into bot.py now, apply the same refactoring and documentation standards, and push the updates to this PR shortly. |
Author
|
Just pushed the updates! I refactored the verbose message-fetching methods in bot.py and added the missing PEP 257 docstrings to the core Bot class and handler. Let me know how it looks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR addresses Issue #20 by refactoring excessively long, Copilot-generated method names and introducing standard PEP 257 docstrings to core functions to improve maintainability.
Changes Made
_update_student_name_if_longer➡️_update_student_name(db.py).require_queue_open_and_not_in_queue➡️can_join_queue(ui/helpers/queue_helpers.py).increment_help,record_bot_issue,get_times_helped_today) and helper functions.Testing