Fix FileNotFoundError when custom template filenames use upper-case PDB codes or extensions - #851
Open
crfield18 wants to merge 2 commits into
Open
Fix FileNotFoundError when custom template filenames use upper-case PDB codes or extensions#851crfield18 wants to merge 2 commits into
crfield18 wants to merge 2 commits into
Conversation
…ectly from PDB use uppercase, causing FileNotFoundError.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
File changed:
AlphaFold2.ipynbIssue
AlphaFold's
_get_pdb_id_and_chain(alphafold/data/templates.py) always lowercases the 4-character PDB code before looking up the template file on disk. The notebook saves uploaded custom templates using their original casing:So uploading e.g.
5HBF.cifcauses:Fix
Normalize the filename's stem and extension to lower case before saving:
Handles
.pdb/.cifuploads in any casing (5HBF.CIF,5hbf.PDB, etc.).