Skip to content

Don't "persist_amounts" in order recalculation#6451

Open
jarednorman wants to merge 1 commit intosolidusio:mainfrom
SuperGoodSoft:more-optimization
Open

Don't "persist_amounts" in order recalculation#6451
jarednorman wants to merge 1 commit intosolidusio:mainfrom
SuperGoodSoft:more-optimization

Conversation

@jarednorman
Copy link
Copy Markdown
Member

This association is autosaved, and Rails knows not to retouch things when autosaving associated records. I did a test to confirm that removing this doesn't change whether the field is persisted.

This association is autosaved, and Rails knows not to retouch things
when autosaving associated records. I did a test to confirm that
removing this doesn't change whether the field is persisted.
@jarednorman jarednorman requested a review from a team as a code owner April 24, 2026 08:34
@jarednorman jarednorman added changelog:solidus_core Changes to the solidus_core gem backport-v4.7 Backport this pull-request to v4.7 labels Apr 24, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.66%. Comparing base (9956911) to head (736babe).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6451      +/-   ##
==========================================
- Coverage   89.66%   89.66%   -0.01%     
==========================================
  Files         990      990              
  Lines       20793    20792       -1     
==========================================
- Hits        18645    18644       -1     
  Misses       2148     2148              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mamhoff
Copy link
Copy Markdown
Contributor

mamhoff commented Apr 30, 2026

This needs a rebase :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-v4.7 Backport this pull-request to v4.7 changelog:solidus_core Changes to the solidus_core gem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants