Skip to content

Enhance Monitor Status callback to include monitor information#486

Merged
lo-simon merged 2 commits intosony:masterfrom
lo-simon:add-monitor-info-on-status-monitor-callback
Apr 30, 2026
Merged

Enhance Monitor Status callback to include monitor information#486
lo-simon merged 2 commits intosony:masterfrom
lo-simon:add-monitor-info-on-status-monitor-callback

Conversation

@lo-simon
Copy link
Copy Markdown
Collaborator

@lo-simon lo-simon commented Apr 2, 2026

Currently, the callback handlers exposed by nmos-cpp return information for all Interfaces, regardless of whether they have an associated Status Monitor. It is making it impossible to display the Interface information associated with a specific Monitor.

Current callback

typedef std::function<std::vector<nc::counter>(void)> get_packet_counters_handler;
typedef std::function<void(void)> reset_monitor_handler;

Updated callback

typedef std::function<std::vector<nc::counter>(const nmos::resource&)> get_packet_counters_handler;
typedef std::function<void(const nmos::resource&)> reset_monitor_handler;

Copy link
Copy Markdown
Contributor

@jonathan-r-thorpe jonathan-r-thorpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lo-simon lo-simon merged commit e978104 into sony:master Apr 30, 2026
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants