Add Taxon tree query button preference for Taxon or Preferred Taxon#7837
Add Taxon tree query button preference for Taxon or Preferred Taxon#7837acwhite211 wants to merge 6 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThis PR adds a new user preference that allows selection between ChangesTaxon Query Field Preference
🚥 Pre-merge checks | ✅ 4 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
emenslin
left a comment
There was a problem hiding this comment.
- Confirm the generated Collection Object query runs and filters through
Determinations > Preferred Taxon > [rank] > Taxon ID. - Confirm the query result count matches the count shown in the Taxon tree for that accepted node.
- Confirm the generated query now filters through
Determinations > Taxon > [rank] > Taxon IDand returns records originally determined to that taxon. - Spot check a non-Taxon tree query, such as Geography or Storage, and confirm the Query button still opens and runs as before.
Looks good, taxon tree queries run based on preference.
bhumikaguptaa
left a comment
There was a problem hiding this comment.
- Confirm the generated Collection Object query runs and filters through
Determinations > Preferred Taxon > [rank] > Taxon ID. - Confirm the query result count matches the count shown in the Taxon tree for that accepted node.
- Confirm the generated query now filters through
Determinations > Taxon > [rank] > Taxon IDand returns records originally determined to that taxon. - Spot check a non-Taxon tree query, such as Geography or Storage, and confirm the Query button still opens and runs as before.
Looks good to me, came across no errors.
Fixes #3724
Add a user preference that controls which determination field the Taxon tree Query button uses when building a query.
Not sure if this is all that is needed to solve #3724 and maybe #4677, need to investigate some more.
Also, need to fix failing unit tests.
Checklist
self-explanatory (or properly documented)
Testing instructions
/specify/user-preferences/treeEditor.Tree Editor > Taxon, confirm there is a preference namedField used by Taxon Query buttonwithPreferred TaxonandTaxonoptions.Preferred Taxon. Do not reload the page./specify/tree/taxon, select an accepted Taxon node whose tree count includes synonymized determinations, and click the Query/magnifying-glass button.Determinations > Preferred Taxon > [rank] > Taxon ID.0when the record’s Preferred Taxon is the accepted node.Field used by Taxon Query buttontoTaxon.Determinations > Taxon > [rank] > Taxon IDand returns records originally determined to that taxon.Summary by CodeRabbit