Changes credentials transmission#7
Open
gluisier wants to merge 19 commits into
Open
Conversation
After a sort of dialogue of the deaf with support, they dropped that: "The engineers confirmed that sending appId/appKey as header parameters is a deprecated feature with no guarantee of future support." Basically moves the headers to query string.
Conflicts: FlightStats/FlightStatsAPIException.php FlightStats/RestClient.php composer.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a sort of dialogue of the deaf with support, they dropped the following.
This PR sets appId and appKey as default query string parameters rather than header values.
Also, this adds all airline and all airports retrieval possibility and (thanks to @adkarta) alerts handling, as well as debug option.
Note: merging this makes closing #2 possible without merging (done in this PR).