Skip to content

Minor Fixes Against False Positive Patterns - #4249

Merged
nasbench merged 10 commits into
developfrom
fix_fp_patterns_0831
Sep 4, 2026
Merged

Minor Fixes Against False Positive Patterns#4249
nasbench merged 10 commits into
developfrom
fix_fp_patterns_0831

Conversation

@onurmerdogan

@onurmerdogan onurmerdogan commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Details

Applied minor fixes to some of the detections that are exhibiting clusters of FP.

Windows Private Keys Discovery

  • Detection was reporting on non-Windows activities
  • dir pattern often mis-matching variables($dir), command line parameters(output-dir), or incorrect commands(mkdir)
  • Key extensions matching objects, paths, domain names etc.

Jscript Execution Using Cscript App

  • Triggers on regular runs of Symantec Host Integrity checks

Comment thread detections/endpoint/windows_private_keys_discovery.yml Outdated
@nasbench nasbench added this to the v6.6.0 milestone Aug 31, 2026
Comment thread detections/deprecated/linux_adding_crontab_using_list_parameter.yml Outdated
Comment thread detections/deprecated/linux_adding_crontab_using_list_parameter.yml Outdated

@nasbench nasbench left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments just as an FYI

@nasbench

nasbench commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-04T18:23:22.372051Z def95a8 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: def95a810c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@nasbench
nasbench merged commit e86ae0f into develop Sep 4, 2026
6 checks passed
@nasbench
nasbench deleted the fix_fp_patterns_0831 branch September 4, 2026 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Linux Adding Crontab Using List Parameter — add redirection coverage, fix Industroyer2 reference

2 participants