Skip to content

Various code polishes - #1674

Open
ngocnhan-tran1996 wants to merge 4 commits into
spring-projects:mainfrom
ngocnhan-tran1996:polish-converter
Open

Various code polishes #1674
ngocnhan-tran1996 wants to merge 4 commits into
spring-projects:mainfrom
ngocnhan-tran1996:polish-converter

Conversation

@ngocnhan-tran1996

Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Tran Ngoc Nhan <ngocnhan.tran1996@gmail.com>
Spring Conversion does not support converting between `String` and `byte[]` while `byte[]` to `byte[]` conversion is supported. This commit adds test cases covering these conversions.

Signed-off-by: Tran Ngoc Nhan <ngocnhan.tran1996@gmail.com>
Signed-off-by: Tran Ngoc Nhan <ngocnhan.tran1996@gmail.com>
Use `toString()` when an attribute value is not a `String`.

Signed-off-by: Tran Ngoc Nhan <ngocnhan.tran1996@gmail.com>
@ngocnhan-tran1996
ngocnhan-tran1996 force-pushed the polish-converter branch 2 times, most recently from c3e09b8 to 0b6ff5d Compare September 2, 2026 13:34
@jzheaux

jzheaux commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

Thanks, @ngocnhan-tran1996! Will you please separate the addition of isLdapSid into a separate PR? That will notify the community of any separate discussion about it and keep the conversation lines a little cleaner.

@ngocnhan-tran1996

Copy link
Copy Markdown
Contributor Author

@jzheaux

I created PR #1687 for the addition of isLdapSid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants