Fix MySQL expression type inference for numeric division#4391
Open
rubensantoniorosa2704 wants to merge 3 commits intosqlc-dev:mainfrom
Open
Fix MySQL expression type inference for numeric division#4391rubensantoniorosa2704 wants to merge 3 commits intosqlc-dev:mainfrom
rubensantoniorosa2704 wants to merge 3 commits intosqlc-dev:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves MySQL expression type inference for simple numeric expressions, with a focus on division.
In November 2025 I started working on this issue but closed my previous attempt because I felt I was changing too much at once. This is a smaller, more focused version of that work, and it’s my first non-trivial contribution to this project.
What this PR does:
The goal is not to provide a complete expression type system, but to address the concrete bug with FLOAT NULL columns and division while leaving clear extension points for future work.
I would really appreciate feedback on:
I’m happy to adjust the approach, change the design if you’d prefer a different direction, add more tests, or explain any part of the implementation if something is unclear.
Fixes #4153