Skip to content

Fix sumi straddr buffer#2689

Merged
jpkenny merged 4 commits into
sstsimulator:develfrom
nab880:fix-sumi-straddr-buffer
Jun 10, 2026
Merged

Fix sumi straddr buffer#2689
jpkenny merged 4 commits into
sstsimulator:develfrom
nab880:fix-sumi-straddr-buffer

Conversation

@nab880

@nab880 nab880 commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Fix a set of memory-safety and API-correctness bugs in sumi_av_straddr — the function that turns a SUMI/libfabric address into a human-readable string.

This caused a segfault (overflow the string buffer) on Ubuntu-24 builds of hgcc.

nab880 added 4 commits June 8, 2026 02:01
@nab880
Fix SUMI straddr buffer sizing.
8ef131d
@nab880
Honor fi_av_straddr buffer contract in sumi_av_straddr.
1bb982c 
Format into the caller-supplied buf and return it instead of leaking a
new[]-allocated buffer; report required size via *len.
@nab880
Bound FI_ADDR_STR copy in sumi_av_straddr.
3c84679 
Use snprintf instead of unbounded strcpy to respect the caller buffer size.
@nab880
Null-check addr/len in sumi_av_straddr.
c2df064 
Return NULL on missing addr or len pointer before dereferencing *len.
@nab880 nab880 requested a review from jpkenny June 9, 2026 05:52
@sst-autotester

sst-autotester commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request.

@sst-autotester

sst-autotester commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: SST__Autotest_sst-test_OMPI-4.1.4_PY3.9_sst-elements

  • Build Num: 2792
  • Status: STARTED

Build Information

Test Name: SST__Autotest_sst-test_OMPI-4.1.4_PY3.9_sst-elements_Make-Dist

  • Build Num: 1556
  • Status: STARTED

Build Information

Test Name: SST__Autotest_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MT-2

  • Build Num: 2733
  • Status: STARTED

Build Information

Test Name: SST__Autotest_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MR-2

  • Build Num: 2735
  • Status: STARTED

Build Information

Test Name: SST__Autotest_OSX-15-XC16_OMPI-4.1.6_PY3.10_sst-elements

  • Build Num: 1269
  • Status: STARTED

Using Repos:

Repo: ELEMENTS (nab880/sst-elements)
  • Branch: fix-sumi-straddr-buffer
  • SHA: c2df064
  • Mode: TEST_REPO
Repo: SQE (sstsimulator/sst-sqe)
  • Branch: devel
  • SHA: 2d8139ae03322b0a07e1ecb0ec4ccc16fd9e0303
  • Mode: SUPPORT_REPO
Repo: CORE (sstsimulator/sst-core)
  • Branch: devel
  • SHA: 2c77bf5456e9ab7606d0446b9ede969a263bd66a
  • Mode: SUPPORT_REPO
Repo: MACRO (sstsimulator/sst-macro)
  • Branch: devel
  • SHA: cd50ac2eb723b7fd3e78b02b65e3a7ba7250c618
  • Mode: SUPPORT_REPO

Pull Request Author: nab880

@sst-autotester

sst-autotester commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: SST__Autotest_sst-test_OMPI-4.1.4_PY3.9_sst-elements

  • Build Num: 2792
  • Status: PASSED

Build Information

Test Name: SST__Autotest_sst-test_OMPI-4.1.4_PY3.9_sst-elements_Make-Dist

  • Build Num: 1556
  • Status: PASSED

Build Information

Test Name: SST__Autotest_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MT-2

  • Build Num: 2733
  • Status: PASSED

Build Information

Test Name: SST__Autotest_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MR-2

  • Build Num: 2735
  • Status: PASSED

Build Information

Test Name: SST__Autotest_OSX-15-XC16_OMPI-4.1.6_PY3.10_sst-elements

  • Build Num: 1269
  • Status: PASSED

@sst-autotester

sst-autotester commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO REVIEWS HAVE BEEN PERFORMED ON THIS PULL REQUEST!

@sst-autotester

sst-autotester commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

jpkenny
jpkenny approved these changes Jun 9, 2026
View reviewed changes

@jpkenny jpkenny left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sst-autotester

sst-autotester commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ jpkenny ]!

@sst-autotester

sst-autotester commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

1 similar comment
@sst-autotester

sst-autotester commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

@jpkenny jpkenny merged commit 0522ce1 into sstsimulator:devel Jun 10, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jpkenny jpkenny jpkenny approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nab880 @sst-autotester @jpkenny