feat: improve security by not returning uncaught exceptions to end-users - #966
Open
StijnCaerts wants to merge 2 commits into
Open
feat: improve security by not returning uncaught exceptions to end-users#966StijnCaerts wants to merge 2 commits into
StijnCaerts wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
By having an exception handler for the Python base
Exception, all uncaught exception messages will be returned to the end-user. For security purposes, it is better to show a generic error message for uncaught exceptions as these might contain sensitive information. On the other hand, error handling for validating and processing user input can be improved in the application itself, eg. by explicitly raising anHTTPExceptionwith code400when parsing of a filter string fails.This PR proposes to remove the exception handler for the
Exceptiontype, as a result end-users will get a genericHTTP 500response without detail of the underlying exception raised.PR Checklist:
pre-commithooks pass locallymake test)make docs)