feat(dom): toBePressed and toBePartiallyPressed#172
Conversation
JDOM10
left a comment
JDOM10
left a comment
There was a problem hiding this comment.
Hey @KeylaMunnoz! Thank you for working on this, this is looking great! Just left a small comment 
Anything else you would like to add? @suany0805
suany0805
left a comment
suany0805
left a comment
There was a problem hiding this comment.
Nice Work! just left a couple of comments
| ); | ||
| } | ||
|
|
||
| const pressedAttribute = this.actual.getAttribute("aria-pressed"); |
There was a problem hiding this comment.
maybe rename to pressedAttributeValue, since I get you could receive: true, false or mixed.
There was a problem hiding this comment.
can you explain what does mixed specifically involve ? (for context and understanding)
There was a problem hiding this comment.
Hey Su sure ! mixed represents a partially pressed state so it's typically used when a toggle button controls multiple items and only some of them are in the pressed state.
In these cases, the button cannot be accurately described as either fully pressed (true) or not pressed (false), so mixed indicates that the controlled state is not consistent across the affected items.
…sages, readability and add examples
3 participants
What has been added: