Implement #2459 (https://github.com/stargate/data-api/issues/2459): allow overrides for "findAndRerank" command#2460
Draft
tatu-at-datastax wants to merge 18 commits intomainfrom
Draft
Conversation
Contributor
Unit Test Coverage Report
|
Contributor
📈 Integration Test Coverage Delta vs Main Branch (dse69-it)
|
Contributor
Integration Test Coverage Report (dse69-it)
|
Contributor
Integration Test Coverage Report (hcd-it)
|
Contributor
📈 Integration Test Coverage Delta vs Main Branch (hcd-it)
|
amorton
requested changes
Apr 28, 2026
| * Optional per-request override for the reranking service configuration. All fields are optional; | ||
| * unspecified fields fall back to the collection's defaults. | ||
| */ | ||
| public record RerankServiceOverride( |
Contributor
There was a problem hiding this comment.
-1 can we reuse the record from CreateCollectionCommand.RerankServiceDesc
| private boolean hasRerankOverride() { | ||
| var override = | ||
| getOrDefault(command.options(), FindAndRerankCommand.Options::rerankServiceOverride, null); | ||
| return override != null && (override.provider() != null || override.modelName() != null); |
Contributor
There was a problem hiding this comment.
there is an isEmpty() on the record, the one on the create collection command is better. we should use that.
| * options with the collection's configured defaults. Result is memoized for the lifetime of this | ||
| * builder. | ||
| */ | ||
| private CollectionRerankDef.RerankServiceDef resolveEffectiveRerankServiceDef( |
Contributor
There was a problem hiding this comment.
-1 - we do not want to merge the two settings, that leads to more complexity than is needed. If there is any per request setting it should override the collection settings
Contributor
Author
There was a problem hiding this comment.
Changed to not merge settings.
tatu-at-datastax
changed the title
Contributor
📈 Unit Test Coverage Delta vs Main Branch
|
Contributor
Author
|
Re-prompted: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds ability to provide rerank provider/model overrides for findAndRerank; see #2459 for details.
Which issue(s) this PR fixes:
Fixes #2459
Checklist