Skip to content

test: migrate math/base/special/atan2d to ULP-based testing#11659

Open
MANDEep22332 wants to merge 1 commit intostdlib-js:developfrom
MANDEep22332:test-atan2d
Open

test: migrate math/base/special/atan2d to ULP-based testing#11659
MANDEep22332 wants to merge 1 commit intostdlib-js:developfrom
MANDEep22332:test-atan2d

Conversation

@MANDEep22332
Copy link
Copy Markdown
Contributor

Progresses #11352

Description

What is the purpose of this pull request?

This pull request:

  • implement the ULP-based-testing

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}


@stdlib-js/reviewers

@MANDEep22332 MANDEep22332 requested a review from a team April 20, 2026 10:22
@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Apr 20, 2026
@kgryte kgryte added difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Tests Pull requests specifically adding tests. review: 5 Needs Changes Pull request which needs changes before being merged. review: 2 and removed Needs Review A pull request which needs code review. review: 5 labels Apr 20, 2026
@kgryte
Copy link
Copy Markdown
Member

kgryte commented Apr 20, 2026

The CI failures need to be addressed before this PR can move forward.

@kgryte kgryte changed the title test: migrate math/base/special/atan2d to ULP-based testing test: migrate math/base/special/atan2d to ULP-based testing Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Good First PR A pull request resolving a Good First Issue. Math Issue or pull request specific to math functionality. Needs Changes Pull request which needs changes before being merged. review: 2 Tests Pull requests specifically adding tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants