Skip to content

feat: add blas/base/ndarray/dswap#11715

Merged
kgryte merged 4 commits intostdlib-js:developfrom
MeKaustubh07:ndarray/dswap
Apr 23, 2026
Merged

feat: add blas/base/ndarray/dswap#11715
kgryte merged 4 commits intostdlib-js:developfrom
MeKaustubh07:ndarray/dswap

Conversation

@MeKaustubh07
Copy link
Copy Markdown
Member

@MeKaustubh07 MeKaustubh07 commented Apr 22, 2026

Description

What is the purpose of this pull request?

This pull request:

  • feat: add blas/base/ndarray/dswap

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

  • #{{TODO: add related issue number}}

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}


@stdlib-js/reviewers

@MeKaustubh07 MeKaustubh07 requested a review from a team April 22, 2026 05:07
@stdlib-bot stdlib-bot added BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Needs Review A pull request which needs code review. labels Apr 22, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Apr 22, 2026

Coverage Report

Package Statements Branches Functions Lines
blas/base/ndarray/dswap $\color{green}117/117$
$\color{green}+0.00%$
$\color{green}3/3$
$\color{green}+0.00%$
$\color{green}1/1$
$\color{green}+0.00%$
$\color{green}117/117$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte added Feature Issue or pull request for adding a new feature. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. review: 5 BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). and removed Needs Review A pull request which needs code review. BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). labels Apr 22, 2026
Comment thread lib/node_modules/@stdlib/blas/base/ndarray/dswap/test/test.js
Comment thread lib/node_modules/@stdlib/blas/base/ndarray/dswap/test/test.js Outdated
Comment thread lib/node_modules/@stdlib/blas/base/ndarray/dswap/test/test.js
Comment thread lib/node_modules/@stdlib/blas/base/ndarray/dswap/README.md
Comment thread lib/node_modules/@stdlib/blas/base/ndarray/dswap/examples/index.js
Copy link
Copy Markdown
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left initial comments.

@kgryte kgryte added review: 2 Needs Changes Pull request which needs changes before being merged. and removed review: 5 labels Apr 22, 2026
@MeKaustubh07 MeKaustubh07 requested a review from kgryte April 22, 2026 15:05
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Apr 22, 2026
@kgryte kgryte removed Needs Changes Pull request which needs changes before being merged. Needs Review A pull request which needs code review. labels Apr 23, 2026
Copy link
Copy Markdown
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@MeKaustubh07 Before opening a PR for (s|c|z)swap, I am going to push some changes to this package in order to modernize the examples. Would be good to wait so that you know what to include in the future PRs.

@kgryte kgryte merged commit 68ef817 into stdlib-js:develop Apr 23, 2026
33 checks passed
@MeKaustubh07
Copy link
Copy Markdown
Member Author

LGTM.

@MeKaustubh07 Before opening a PR for (s|c|z)swap, I am going to push some changes to this package in order to modernize the examples. Would be good to wait so that you know what to include in the future PRs.

@kgryte Okay!, I will move forward with other Level 1 packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Feature Issue or pull request for adding a new feature. review: 2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants