chore: propagate recent fixes to sibling packages#11723
Open
Planeshifter wants to merge 2 commits intodevelopfrom
Open
chore: propagate recent fixes to sibling packages#11723Planeshifter wants to merge 2 commits intodevelopfrom
Planeshifter wants to merge 2 commits intodevelopfrom
Conversation
Propagates fix from 11fe978 ("chore: minor clean-up") to the sdiff sibling: corrects "to differences of every other element" → "to compute differences of every other element" to match the ddiff phrasing.
…crete-uniform/*` Propagates fix from 80a434f ("refactor: remove unneeded `isnan` checks") to the discrete-uniform sibling distribution: removes the redundant `isnan( a )` / `isnan( b )` clauses (and their `is-nan` require) from mean, variance, entropy, kurtosis, skewness, stdev, and median. `!isInteger( a )` / `!isInteger( b )` already short-circuit to `return NaN` for NaN inputs, so the `isnan` calls are dead code.
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Propagating fixes merged to
developbetween 2026-04-21T04:45Z and 2026-04-22T13:30Z to sibling packages with the same underlying defect.Source:
11fe9784— docs typoPropagates the typo fix from
11fe9784, which corrected a missing verb in the example intro sentence ofddiff's README ("to differences" → "to compute differences"). Applied the identical correction toblas/ext/base/sdiff, the float32 sibling. No logic changes.lib/node_modules/@stdlib/blas/ext/base/sdiff/README.mdSource:
80a434fd— redundantisnanguardsPropagates
80a434fd, which removed redundantisnanpre-checks that are already subsumed by!isInteger()— sinceisInteger(NaN)returnsfalse, the explicit NaN guards are dead code. Applies the same removal (two guard clauses plus theis-nanrequire) across the sevenstats/base/dists/discrete-uniform/distribution properties:mean,variance,entropy,kurtosis,skewness,stdev, andmedian. Sibling files coveringcdf,logcdf,logpmf,pmf,quantile, andmgfare excluded because they additionally guard continuous inputs (e.g.,isnan(x),isnan(p),isnan(t)) that have no equivalent named validator, so partial removal there requires adaptation beyond the scope of the source commit.lib/node_modules/@stdlib/stats/base/dists/discrete-uniform/mean/lib/main.jslib/node_modules/@stdlib/stats/base/dists/discrete-uniform/variance/lib/main.jslib/node_modules/@stdlib/stats/base/dists/discrete-uniform/entropy/lib/main.jslib/node_modules/@stdlib/stats/base/dists/discrete-uniform/kurtosis/lib/main.jslib/node_modules/@stdlib/stats/base/dists/discrete-uniform/skewness/lib/main.jslib/node_modules/@stdlib/stats/base/dists/discrete-uniform/stdev/lib/main.jslib/node_modules/@stdlib/stats/base/dists/discrete-uniform/median/lib/main.jsRelated Issues
None.
Questions
No.
Other
Validation
80a434fd— alllib/node_modules/@stdlib/stats/base/dists/**/lib/main.jsrequiring@stdlib/math/base/assert/is-nan(406 files narrowed to 39 with a named validator + isnan guard, then read in full).11fe9784— full reporgfor"to differences of every other element".discrete-uniformtargets in full and separately returnedconfirmedfor all seven. A Sonnet style-consistency pass re-verified that each post-removal imports block remains correctly ordered and that untouched sibling files (e.g.discrete-uniform/cdf) legitimately retain theirisnan(x)guards.needs-humanor out of scope):negative-binomial/mean— exact two-block shape match, but the next block has no named validator (onlyr <= 0.0,p < 0.0,p > 1.0). Behavior is preserved only via arithmetic NaN propagation, a weaker guarantee than the source commit's intent.hypergeometric/{cdf,logpmf,pmf,quantile}—isnan(N/K/n)are redundant butisnan(x)/isnan(p)gate continuous inputs; partial removal is adaptive, not mechanical.binomial/*(13 files),erlang/*(8 files),discrete-uniform/{cdf,logcdf,logpmf,pmf,quantile,mgf}— same reason: remainingisnan(x)/isnan(p)/isnan(t)clauses are not covered by any named validator.1089250d(missingeslint-disable stdlib/no-new-arrayinsin-by/test/test.ndarray.js) — search confirmed every othermath/strided/{special,ops}/*-by/test/test.*.jsalready carries the comment frombf821ca6. No remaining sites.refactor!:NaN-check removals innumber/{int32,uint32}/base/muldw, README indentation normalization instats/base/ndarray/dmaxsorted, rot90 description rewrite, migration-guide phrasing tweaks) — each is either a breaking API change or specific to a single file with no sibling that matches the exact pattern.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was produced by Claude Code running the fix-propagation routine: it enumerated fixes merged to
developin the last 24 hours, extracted pattern signatures, searched for sibling sites, and filtered candidates through independent validation agents. Each landed change was reviewed against the original commit's intent before inclusion.