chore: propagate recent fixes to sibling packages#11904
Draft
Planeshifter wants to merge 2 commits intodevelopfrom
Draft
chore: propagate recent fixes to sibling packages#11904Planeshifter wants to merge 2 commits intodevelopfrom
Planeshifter wants to merge 2 commits intodevelopfrom
Conversation
Propagates fix from ec1d66c (`fix: correct C delegation and benchmark inputs in stats/strided/dpcorr`) to sibling packages where an `_ndarray` function delegates to another `_ndarray` without `API_SUFFIX(...)` wrapping, plus the analogous `x`/`y` benchmark mix-up in `stats/strided/dpcorrwd`.
Propagates fix from acd2375 (`style: resolve lint error in ndarray/fancy`) to the sibling `ndarray/ctor` `get_nd` test, replacing `new Array( shape.length )` plus indexed assignment with `[]` plus `push()` to clear the `no-new-Array-with-non-literal` lint rule.
develop to sibling packages
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
developbetween 2026-05-02 21:43 EDT (c2b92b4e) and 2026-05-03 04:42 PDT (186eaa37f) to sibling packages with the same underlying defect.stats/strided/*C delegation and benchmark fixes (ec1d66c)Propagates two bugs fixed in
dpcorr: bare_ndarraydelegations insideAPI_SUFFIX(...)-prefixed wrappers that break differentiated-symbol builds, and a benchmark input mix-up wherexwas passed twice instead ofx/y.API_SUFFIX(...)missing on inner_ndarraycalls:stats/strided/dsmean/src/main.cstats/strided/dsmeanors/src/main.cstats/strided/dsmeanpw/src/main.cstats/strided/distances/deuclidean/src/main.cstats/strided/distances/dsquared-euclidean/src/main.cstats/strided/distances/dminkowski/src/main.c(three call sites)Benchmark
x/ymix-up:stats/strided/dpcorrwd/benchmark/c/benchmark.length.cndarray/ctorlint fix (acd2375)Propagates the same
no-new-Array-with-non-literalfix fromndarray/fancy(acd2375) to the sibling package. Replacesnew Array( shape.length )with[]pluspushin thebadValuefactory ofndarray/ctor/test/test.instance.get_nd.js.Related Issues
No.
Questions
No.
Other
Validation
stats/strided/**/src/main.cfor theAPI_SUFFIX(...)delegation pattern;stats/strided/**/benchmark/c/*.cfor thexduplication pattern;lib/node_modules/@stdlib/**/test/**/*.jsfor thenew Array(<non-literal>)lint pattern._ndarrayfunction isAPI_SUFFIX(...)-wrapped, (b) the call target is alsoAPI_SUFFIX(...)-defined, and (c) other delegations within the same file already useAPI_SUFFIX(...), so the bare call is anomalous rather than intentional.API_SUFFIX(stdlib_strided_X_ndarray)with no inner spaces matches the source-commit style across all six C files; the JS lint fix matchesndarray/fancy's tab indentation and one-var-per-line convention.Deliberately excluded
pkg+':...'→format( '%s:...', pkg )benchmark cleanup from 822fadc: search acrosslib/node_modules/@stdlib/**/benchmark/**/*.jsreturns 737 hits across many namespaces; sibling scope (utils/*) is already fully clean from the source commit. Mass-applying outside that scope is "while we're here" territory and dropped from this run.lib/node_modules/@stdlib/**/test/fixtures/**/*.jsonfinds zero remaining sites. Non-fixture data JSON underdatasets/moby-dick/data/*.jsonis excluded as out-of-pattern.needs-humanby validation agents this run.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was generated by Claude Code running an automated fix-propagation routine: it scanned commits merged to
developin the prior 24 hours, derived structural fix-pattern signatures, ran two independent validation agents plus an adaptation pass and a style-consistency pass over candidate sibling sites, and applied only the patches that survived all four agents' verdicts. A maintainer will audit and promote out of draft.@stdlib-js/reviewers
Generated by Claude Code