Skip to content

chore: propagate recent fixes to sibling packages#11904

Draft
Planeshifter wants to merge 2 commits intodevelopfrom
philipp/fix-propagation-2026-05-03
Draft

chore: propagate recent fixes to sibling packages#11904
Planeshifter wants to merge 2 commits intodevelopfrom
philipp/fix-propagation-2026-05-03

Conversation

@Planeshifter
Copy link
Copy Markdown
Member

Description

What is the purpose of this pull request?

This pull request:

  • Propagates fixes merged to develop between 2026-05-02 21:43 EDT (c2b92b4e) and 2026-05-03 04:42 PDT (186eaa37f) to sibling packages with the same underlying defect.

stats/strided/* C delegation and benchmark fixes (ec1d66c)

Propagates two bugs fixed in dpcorr: bare _ndarray delegations inside API_SUFFIX(...)-prefixed wrappers that break differentiated-symbol builds, and a benchmark input mix-up where x was passed twice instead of x/y.

API_SUFFIX(...) missing on inner _ndarray calls:

  • stats/strided/dsmean/src/main.c
  • stats/strided/dsmeanors/src/main.c
  • stats/strided/dsmeanpw/src/main.c
  • stats/strided/distances/deuclidean/src/main.c
  • stats/strided/distances/dsquared-euclidean/src/main.c
  • stats/strided/distances/dminkowski/src/main.c (three call sites)

Benchmark x/y mix-up:

  • stats/strided/dpcorrwd/benchmark/c/benchmark.length.c

ndarray/ctor lint fix (acd2375)

Propagates the same no-new-Array-with-non-literal fix from ndarray/fancy (acd2375) to the sibling package. Replaces new Array( shape.length ) with [] plus push in the badValue factory of ndarray/ctor/test/test.instance.get_nd.js.

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Validation

  • Pattern search scope: stats/strided/**/src/main.c for the API_SUFFIX(...) delegation pattern; stats/strided/**/benchmark/c/*.c for the x duplication pattern; lib/node_modules/@stdlib/**/test/**/*.js for the new Array(<non-literal>) lint pattern.
  • Two independent validation agents read each candidate file in full and confirmed that (a) the enclosing _ndarray function is API_SUFFIX(...)-wrapped, (b) the call target is also API_SUFFIX(...)-defined, and (c) other delegations within the same file already use API_SUFFIX(...), so the bare call is anomalous rather than intentional.
  • Style-consistency pass confirmed API_SUFFIX(stdlib_strided_X_ndarray) with no inner spaces matches the source-commit style across all six C files; the JS lint fix matches ndarray/fancy's tab indentation and one-var-per-line convention.

Deliberately excluded

  • The pkg+':...'format( '%s:...', pkg ) benchmark cleanup from 822fadc: search across lib/node_modules/@stdlib/**/benchmark/**/*.js returns 737 hits across many namespaces; sibling scope (utils/*) is already fully clean from the source commit. Mass-applying outside that scope is "while we're here" territory and dropped from this run.
  • The trailing-newline JSON-fixture fix from c2b92b4e: scan of lib/node_modules/@stdlib/**/test/fixtures/**/*.json finds zero remaining sites. Non-fixture data JSON under datasets/moby-dick/data/*.json is excluded as out-of-pattern.
  • No sites were flagged needs-human by validation agents this run.
  • No adaptive fixes required cross-package edits or new dependencies; all patches are single-file.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

This PR was generated by Claude Code running an automated fix-propagation routine: it scanned commits merged to develop in the prior 24 hours, derived structural fix-pattern signatures, ran two independent validation agents plus an adaptation pass and a style-consistency pass over candidate sibling sites, and applied only the patches that survived all four agents' verdicts. A maintainer will audit and promote out of draft.


@stdlib-js/reviewers


Generated by Claude Code

claude added 2 commits May 3, 2026 13:30
Propagates fix from ec1d66c (`fix: correct C delegation and benchmark
inputs in stats/strided/dpcorr`) to sibling packages where an `_ndarray`
function delegates to another `_ndarray` without `API_SUFFIX(...)`
wrapping, plus the analogous `x`/`y` benchmark mix-up in
`stats/strided/dpcorrwd`.
Propagates fix from acd2375 (`style: resolve lint error in
ndarray/fancy`) to the sibling `ndarray/ctor` `get_nd` test, replacing
`new Array( shape.length )` plus indexed assignment with `[]` plus
`push()` to clear the `no-new-Array-with-non-literal` lint rule.
@Planeshifter Planeshifter changed the title Propagate recent fixes from develop to sibling packages chore: propagate recent fixes to sibling packages May 3, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
ndarray/ctor $\color{red}801/806$
$\color{green}+99.38%$
$\color{red}109/112$
$\color{green}+97.32%$
$\color{green}7/7$
$\color{green}+100.00%$
$\color{red}801/806$
$\color{green}+99.38%$
stats/strided/distances/deuclidean $\color{green}366/366$
$\color{green}+100.00%$
$\color{green}15/15$
$\color{green}+100.00%$
$\color{green}4/4$
$\color{green}+100.00%$
$\color{green}366/366$
$\color{green}+100.00%$
stats/strided/distances/dminkowski $\color{green}400/400$
$\color{green}+100.00%$
$\color{green}23/23$
$\color{green}+100.00%$
$\color{green}4/4$
$\color{green}+100.00%$
$\color{green}400/400$
$\color{green}+100.00%$
stats/strided/distances/dsquared-euclidean $\color{green}366/366$
$\color{green}+100.00%$
$\color{green}15/15$
$\color{green}+100.00%$
$\color{green}4/4$
$\color{green}+100.00%$
$\color{green}366/366$
$\color{green}+100.00%$
stats/strided/dpcorrwd $\color{red}511/513$
$\color{green}+99.61%$
$\color{red}18/19$
$\color{green}+94.74%$
$\color{green}4/4$
$\color{green}+100.00%$
$\color{red}511/513$
$\color{green}+99.61%$
stats/strided/dsmean $\color{green}346/346$
$\color{green}+100.00%$
$\color{green}13/13$
$\color{green}+100.00%$
$\color{green}4/4$
$\color{green}+100.00%$
$\color{green}346/346$
$\color{green}+100.00%$
stats/strided/dsmeanors $\color{green}351/351$
$\color{green}+100.00%$
$\color{green}18/18$
$\color{green}+100.00%$
$\color{green}4/4$
$\color{green}+100.00%$
$\color{green}351/351$
$\color{green}+100.00%$
stats/strided/dsmeanpw $\color{green}351/351$
$\color{green}+100.00%$
$\color{green}18/18$
$\color{green}+100.00%$
$\color{green}4/4$
$\color{green}+100.00%$
$\color{green}351/351$
$\color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants