style: align outliers in stats/base/dists/logistic with namespace majority patterns#11914
Closed
Planeshifter wants to merge 2 commits intodevelopfrom
Closed
style: align outliers in stats/base/dists/logistic with namespace majority patterns#11914Planeshifter wants to merge 2 commits intodevelopfrom
stats/base/dists/logistic with namespace majority patterns#11914Planeshifter wants to merge 2 commits intodevelopfrom
Conversation
…ions Add Julia fixture infrastructure (`test/fixtures/julia/REQUIRE` and `test/fixtures/julia/runner.jl`) to match the namespace convention used by 13/15 sibling packages (87%). The runner mirrors `stats/base/dists/logistic/variance/test/fixtures/julia/runner.jl`, substituting `Distributions.std` for `Distributions.var`. Existing Python fixtures are left untouched; switching the test suite over to the Julia data is left to a follow-up maintainer call.
… Julia runner Lint Copyright Years CI failed because the file was scaffolded from the 2018-vintage `variance/test/fixtures/julia/runner.jl` template without resetting the year on a newly added file.
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Aligning outliers in
stats/base/dists/logisticwith namespace majority patterns (random namespace pick, seed20260503).Namespace summary
package.jsonshape,manifest.jsonshape, README section ordering, test/benchmark/example file naming, public signature, validation prologue, error construction, JSDoc shape,@stdlib/*dependency seterrorConstruction(onlyctorthrows — others returnNaN); validation-prologue scale guard splits cleanly along a mathematical fault line — 8 zero-arg(mu, s)functions uses <= 0.0, 6 parameterized(x|t|p, mu, s)functions uses < 0.0to keep thes == 0degenerate-distribution branch reachableOutlier package:
stats/base/dists/logistic/stdevstats/base/dists/logistic/stdevis missingtest/fixtures/julia/REQUIREandtest/fixtures/julia/runner.jl, which 13 of 15 sibling packages instats/base/dists/logistic(87%) ship as standard fixture infrastructure;stdevandctorare the only packages without it, butctoris exempt by convention, makingstdevthe sole non-conforming outlier. Added the two Julia files mirroringvariance/test/fixtures/julia/runner.jlwithDistributions.varswapped forDistributions.std; existing Python/scipy fixtures are left in place.Related Issues
None.
Questions
None.
Other
Validation
Three independent agents reviewed the drift findings before any commits were made:
ctor's use offormat-built throws is intentional given its constructor contract.stdev/test/test.jsonly requires./fixtures/python/data.json, so adding Julia files is purely additive; no sibling referencesstdev's fixture path; thevarianceJulia runner is directly adaptable.ctor's missing native files are intentional (nogypfile, no native code); confirmed theNotessection inlogcdf/logpdfREADMEs documents log-domain numerical stability (intentional deviation, not drift).Deliberately excluded from this PR:
ctormissingbinding.gyp,manifest.json,lib/native.js,src/*,include.gypi,examples/c/*,benchmark/c/*,benchmark/benchmark.native.js,test/test.native.js, plus the Julia fixture pair —ctoris a pure-JS constructor with no native implementation; all native infrastructure is structurally inapplicable.logcdf/logpdfextraNotesREADME section — documents log-domain overflow/underflow guidance that does not apply to non-log siblings.errorConstructionfeature — no clear majority (onlyctorthrows).stdev'stest.jsfrom Python to Julia fixture data — would require regenerating fixture values under a different RNG and changing test inputs; out of scope for a mechanical drift correction.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code running the cross-package drift-detection routine. The routine randomly picked the
stats/base/dists/logisticnamespace (seed20260503), extracted structural and semantic features from all 15 member packages, computed the 75% majority pattern per feature, and validated outliers via three parallel review agents (Opus semantic, Opus cross-reference, Sonnet structural). Only the one drift correction whose three agents unanimously cleared asconfirmed-driftadvanced to a commit.Generated by Claude Code