fix(python): improve Python project detection logic#44
Merged
ashishkurmi merged 2 commits intostep-security:mainfrom Apr 28, 2026
Merged
fix(python): improve Python project detection logic#44ashishkurmi merged 2 commits intostep-security:mainfrom
ashishkurmi merged 2 commits intostep-security:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Improves Python project detection by identifying virtual environments more reliably across different layouts and naming conventions.
Changes:
- Adds venv detection via
pyvenv.cfg(PEP 405) with fallback heuristics for legacy virtualenvs and Windows layouts. - Updates directory walking logic to report detected venvs and avoid descending into them.
- Expands unit tests to cover arbitrary venv names, multiple venvs under one parent, legacy venvs, false positives, and Windows layout.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| internal/detector/pythonproject.go | Reworks Python “project” detection to key off venv structure (pyvenv.cfg / pip / activate) and changes reporting behavior to emit venv paths. |
| internal/detector/pythonpm_test.go | Adds/updates tests validating the new Python venv detection behavior across several scenarios. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
shubham-stepsecurity
force-pushed
the
sm/fix
branch
from
7fc7fbd to
c740fec
Compare
ashishkurmi
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Type of change
Testing
./stepsecurity-dev-machine-guard --verbose./stepsecurity-dev-machine-guard --json | python3 -m json.toolmake lintmake testRelated Issues