Add function to handle Servers metadata#484
Conversation
We are going to use the metadata field to mark certain Servers that require actions. For example, to mark the Servers that are running an EOL version of the Operating System and when the user was notified about it. These 2 functions just perform the set and delete steps. The exact content and format of the parameters is responsibility of the workflows code calling them.
|
these functions are just calling openstacksdk's built-in method can't we just call these built-in methods directly in any action/API function that needs to set metadata instead of creating a whole new function that once again verifies that the server exists (slowing down the process by adding an unnecessary API call I could see this being useful if you're putting some global validation checks on the properties that is unique to us - but maybe you should just wait until there's a use-case like that before creating these functions? I'm wary of adding more code we need to maintain |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #484 +/- ##
=======================================
Coverage 99.19% 99.19%
=======================================
Files 112 112
Lines 2725 2735 +10
Branches 338 338
=======================================
+ Hits 2703 2713 +10
Misses 19 19
Partials 3 3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
We are going to use the metadata field to mark certain Servers that require actions.
For example, to mark the Servers that are running an EOL version of the Operating System and when the user was notified about it.
These 2 functions just perform the set and delete steps. The exact content and format of the parameters is responsibility of the workflows code calling them.
Description:
Special Notes:
Submitter:
Have you (where applicable):
Reviewer
Does this PR:
libdirectory?liblayers?