Skip to content

fix(namespace): remove stale backlog quota on type switch - #418

Merged
freeznet merged 6 commits into
mainfrom
freeznet/fix-remove-backlog-quota-type
Jul 28, 2026
Merged

fix(namespace): remove stale backlog quota on type switch#418
freeznet merged 6 commits into
mainfrom
freeznet/fix-remove-backlog-quota-type

Conversation

@freeznet

Copy link
Copy Markdown
Member

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@freeznet freeznet self-assigned this Jul 25, 2026
Copilot AI review requested due to automatic review settings July 25, 2026 03:05
@freeznet
freeznet requested review from a team as code owners July 25, 2026 03:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

Copy link
Copy Markdown
Contributor

@freeznet:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions github-actions Bot added the doc-info-missing This pr needs to mark a document option in description label Jul 25, 2026

@jiangpengcheng jiangpengcheng left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the inline finding.

Comment thread pkg/admin/impl.go

@jiangpengcheng jiangpengcheng left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the inline finding.

Comment thread pkg/admin/impl.go Outdated

@jiangpengcheng jiangpengcheng left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the latest head. The prior findings are addressed, and the relevant tests and CI checks pass.

@freeznet
freeznet merged commit 5462cdd into main Jul 28, 2026
5 checks passed
@freeznet
freeznet deleted the freeznet/fix-remove-backlog-quota-type branch July 28, 2026 03:37
freeznet added a commit that referenced this pull request Jul 28, 2026
* fix(namespace): remove stale backlog quota on type switch

* fix ci

* fix work sum

* fix

* address comments

* address comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-info-missing This pr needs to mark a document option in description

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants