Reject composite fields selected without a subfield selection - #647
Open
apoorva-01 wants to merge 1 commit into
Open
Reject composite fields selected without a subfield selection#647apoorva-01 wants to merge 1 commit into
apoorva-01 wants to merge 1 commit into
Conversation
They were silently resolving to an empty object instead of erroring, which the GraphQL spec disallows.
apoorva-01
marked this pull request as ready for review
August 19, 2026 21:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
{ accountCollection }with no subfields returns an empty object instead of erroring, which the spec doesn't allow. Fixed innormalize_selection_setso all composite fields are covered, and@skip-ing everything still hits the old error path. Added a test; all 122 pass, reverting the fix fails it.Closes #412