Skip to content

feat: rtl support, phase 2#3113

Open
artem-harbour wants to merge 1 commit intomainfrom
artem/rtl-v1
Open

feat: rtl support, phase 2#3113
artem-harbour wants to merge 1 commit intomainfrom
artem/rtl-v1

Conversation

@artem-harbour
Copy link
Copy Markdown
Contributor

@artem-harbour artem-harbour commented May 4, 2026

Linear: SD-2808

  1. Completed Phase 2 RTL body interaction scope.
  2. Removed legacy paragraph rtl usage from the layout path and standardized on direction as the single source of truth.
  3. Added section-direction fallback handling and hardened section bidi parsing (w:val and val support).
  4. Fixed RTL caret geometry issues:
    1. boundary fallback behavior in CaretGeometry
    2. mid-line RTL caret X calculation (not only offset 0)
  5. Implemented visual-line Home/End handling in vertical navigation and stabilized related behavior tests.
  6. Fixed RTL/LTR style transition in DomPainter by clearing stale dir/direction when returning to LTR.
  7. Improved run-based direction inference to majority-based logic with deterministic tie-breaker.
  8. Expanded/stabilized RTL behavior coverage for:
    1. ArrowLeft/ArrowRight
    2. Shift+ArrowLeft/Shift+ArrowRight
    3. Home/End
    4. Select All in RTL document
    5. typing in a newly created empty RTL paragraph

Note:

  • For RTL validation, Hebrew should be used as the primary test language; mixed-direction behavior will be tested/fixed separately.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@artem-harbour artem-harbour force-pushed the artem/rtl-v1 branch 4 times, most recently from 687b133 to 11f7781 Compare May 4, 2026 17:15
@artem-harbour artem-harbour marked this pull request as ready for review May 4, 2026 17:43
@artem-harbour artem-harbour requested a review from a team as a code owner May 4, 2026 17:43
@linear
Copy link
Copy Markdown

linear Bot commented May 4, 2026

@artem-harbour artem-harbour requested review from caio-pizzol, chittolinag and luccas-harbour and removed request for chittolinag May 4, 2026 17:43
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 11f77811ff

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread packages/layout-engine/pm-adapter/src/internal.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants