Fix Play Store user ID hashing - #449
Merged
Merged
Conversation
ianrumac
marked this pull request as ready for review
August 10, 2026 13:03
The test asserted externalAccountId equals sha256-of-user-123 but never stubbed storage.read(AppUserId), so userId fell back to the generated anonymous alias. Stub the stored app user ID like the sibling test does. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UL13jCN87cPLKtmZnTYUrb
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The DependencyContainer lambda used this.toString() inside its body. In that scope, this was the DependencyContainer instance rather than the user ID parameter, so the external account ID was independent of the user and changed with the container instance.
Checks
Full Gradle tests could not be configured in this environment because no Android SDK or sdk.dir is installed. Java 21 configuration succeeded up to the Android SDK check.