fix(deps): exclude @types/* packages from component peer dependencies

[davidfirst]

When @types/* packages are listed as peers in env.jsonc, they were incorrectly being added to components' peer dependencies.

The fix excludes @types/* packages from component dependencies entirely when they're in the env's peers. This is correct because:

• When a component is installed, its env is installed alongside it
• Packages in env.jsonc peers become runtime dependencies of the env itself
• Since @types/* packages are only needed for TypeScript compilation (handled by the env), components don't need them in their own dependencies

[Copilot]

Pull request overview

This PR fixes an issue where @types/* packages listed as peer dependencies in env.jsonc were incorrectly being added to components' peer dependencies. Since these TypeScript type definition packages are only needed for compilation (handled by the environment), and the env is always installed alongside components, there's no need for components to declare them as their own dependencies.

Changes:

• Added logic to exclude @types/* packages from component dependencies when they appear in env peer dependencies
• Includes comprehensive inline documentation explaining the rationale

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

[qodo-free-for-open-source-projects]

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0)

1. Stale missing @types issue 🐞 Bug ≡ Correctness

Description

handlePeerDependencyOverride() removes @types/* packages from the component dependency maps and
returns early, but does not remove the same package from an already-populated
MissingPackagesDependenciesOnFs issue. This can incorrectly keep the component in a tag-blocking
“missing packages” state even though @types/* was intentionally excluded from the component
dependencies.

Code

scopes/dependencies/dependencies/dependencies-loader/apply-overrides.ts[R661-670]

+    // @types/* packages should not be added to components at all when in env peers.
+    // When a component is installed in a workspace, its env is installed as well.
+    // Packages listed as peers in env.jsonc become runtime dependencies of the env itself,
+    // so they're always installed alongside the env. Since @types/* packages are only needed
+    // for TypeScript compilation (which the env handles), there's no need for components
+    // to have them in their own dependencies.
+    if (pkgName.startsWith('@types/')) {
+      delete this.allPackagesDependencies.peerPackageDependencies[pkgName];
+      return true;
+    }

Evidence

The new @types/* early-return path removes the dependency from dependency maps, but nothing updates
the missing-packages issue list. Missing packages are recorded into MissingPackagesDependenciesOnFs
during auto-detection and then propagated onto component.issues, which is used by status/tag flows;
leaving stale entries can therefore incorrectly mark the component as having tag-blocking issues.

scopes/dependencies/dependencies/dependencies-loader/apply-overrides.ts[653-670]
scopes/dependencies/dependencies/dependencies-loader/auto-detect-deps.ts[741-752]
scopes/dependencies/dependencies/dependencies-loader/dependencies-loader.ts[155-171]
components/component-issues/component-issue.ts[17-23]
scopes/component/status/status.main.runtime.ts[145-172]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
When env peers include an `@types/*` package, `handlePeerDependencyOverride()` deletes the dependency entries and returns early. If `MissingPackagesDependenciesOnFs` already contains that `@types/*` package (e.g. the env hasn't been installed yet), the issue remains on the component even though the dependency was intentionally removed, potentially blocking tag.

### Issue Context
- `MissingPackagesDependenciesOnFs` is a tag-blocking issue by default.
- Current logic removes `@types/*` from `allPackagesDependencies` only, without cleaning existing issues data.

### Fix Focus Areas
- scopes/dependencies/dependencies/dependencies-loader/apply-overrides.ts[653-684]

### Suggested fix
- In `handlePeerDependencyOverride()`, before returning `true` for `@types/*`, remove `pkgName` from `MissingPackagesDependenciesOnFs` issue data:
 - Filter `missingPackages` arrays to exclude `pkgName`
 - Drop entries where `missingPackages` becomes empty
 - If the issue data array becomes empty, delete the issue entirely (`this.issues.delete(IssuesClasses.MissingPackagesDependenciesOnFs)`)
- Keep the deletion from `allPackagesDependencies.*` as-is.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

---

Previous review results

Review updated until commit f9964c2

Results up to commit f67480f

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Results up to commit ec32978

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

[qodo-free-for-open-source-projects]

Code review by qodo was updated up to the latest commit f67480f

[qodo-free-for-open-source-projects]

Code review by qodo was updated up to the latest commit f9964c2

[qodo-free-for-open-source-projects]

1. Stale missing @types issue 🐞 Bug ≡ Correctness

handlePeerDependencyOverride() removes @types/* packages from the component dependency maps and
returns early, but does not remove the same package from an already-populated
MissingPackagesDependenciesOnFs issue. This can incorrectly keep the component in a tag-blocking
“missing packages” state even though @types/* was intentionally excluded from the component
dependencies.

Agent Prompt

### Issue description
When env peers include an `@types/*` package, `handlePeerDependencyOverride()` deletes the dependency entries and returns early. If `MissingPackagesDependenciesOnFs` already contains that `@types/*` package (e.g. the env hasn't been installed yet), the issue remains on the component even though the dependency was intentionally removed, potentially blocking tag.

### Issue Context
- `MissingPackagesDependenciesOnFs` is a tag-blocking issue by default.
- Current logic removes `@types/*` from `allPackagesDependencies` only, without cleaning existing issues data.

### Fix Focus Areas
- scopes/dependencies/dependencies/dependencies-loader/apply-overrides.ts[653-684]

### Suggested fix
- In `handlePeerDependencyOverride()`, before returning `true` for `@types/*`, remove `pkgName` from `MissingPackagesDependenciesOnFs` issue data:
  - Filter `missingPackages` arrays to exclude `pkgName`
  - Drop entries where `missingPackages` becomes empty
  - If the issue data array becomes empty, delete the issue entirely (`this.issues.delete(IssuesClasses.MissingPackagesDependenciesOnFs)`)
- Keep the deletion from `allPackagesDependencies.*` as-is.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools