Implement planned topic: 0017-jackson-3#184
Closed
skill-temporal-developer-updater[bot] wants to merge 1 commit into
Closed
Implement planned topic: 0017-jackson-3#184skill-temporal-developer-updater[bot] wants to merge 1 commit into
skill-temporal-developer-updater[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validation Report —
jackson-3(Temporal Java SDK integration)Branch:
draft/0017-jackson-3Files under validation:
references/java/integrations/jackson-3.md(new, 132 lines)references/integrations.md(one row appended)Source of truth:
../documentation/docs/, specifically:docs/develop/java/best-practices/converters-and-encryption.mdxdocs/develop/java/workflows/basics.mdxdocs/develop/java/activities/basics.mdxGo/no-go
Overall verdict: GO
The file is intentionally a "forward-looking" placeholder for a topic (Jackson 3 payload conversion) that is not yet documented in the local
../documentation/clone. The authoring strategy — document the Jackson-2 status quo, then enumerate every Jackson-3 question with<!-- VERIFY: -->blocks and an explicit anti-fabrication checklist — is a sound response to that constraint. All factual claims in the file are grounded in cited docs; all unverified candidate names are explicitly framed as candidates to confirm or prohibitions.Check 1 findings
None. All 10 cited spans resolve cleanly and substantively support the authored claims.
Check 2 findings
None. All factual Temporal-Java tokens resolve in the docs clone:
JacksonJsonPayloadConverterDefaultDataConverterwithPayloadConverterOverridesnewDefaultInstanceWorkflowClientOptionsgetEncodingTypesetDataConverterPayloadConverterObjectMapper"json/plain"Non-Temporal token:
tools.jackson.*(mentioned at line 13 of the skill). Properly tagged<!-- jackson-upstream: package rename and builder-only mapper construction in Jackson 3.x; treat as a Jackson-project fact, not a Temporal-documented fact -->. Acceptable.Negative check (verifying the file's "not yet documented" framing is itself accurate): every
<!-- VERIFY -->candidate name (Jackson3JsonPayloadConverter,useJackson3,withJackson3,newJackson3Instance,temporal-jackson3, "Jackson 3" prose) returned zero matches in the docs clone. The file's framing is accurate.Check 3 findings
None.
--profile,TEMPORAL_TLS_CLIENT_CERT_PATH,tcld service-account,--output text|jsonl,saas-api.tmprl.cloud:7233, etc.): zero hits.Jackson3JsonPayloadConverter,useJackson3,withJackson3,newJackson3Instance,temporal-jackson3appearing as factual claims rather than VERIFY candidates): every occurrence is correctly contained inside a<!-- VERIFY: -->block (lines 61-63, 73, 84) or inside the explicit anti-fabrication checklist that prohibits them (lines 107-109).Check 4 findings
One minor nuance flagged; no substantive divergence.
Nuance (claim 4, file line 21):
PayloadConverterin order; the first one whose encoding type matches handles the conversion."The cited paragraph is about the encoding direction, where dispatch is by data type. Encoding-type metadata (
getEncodingType()) drives decoding dispatch. The authored sentence conflates the two directions. A reader following the authored version still callswithPayloadConverterOverridescorrectly — the practical action is unchanged — so this is a conceptual nuance, not a substantive misdirection. Not enough to fail Check 4.Minor wording drifts (claims 2, 3, 6, 7):
Docs say "should be serializable by the default Jackson JSON Payload Converter"; authored says "must be serializable". The strict-serializability requirement is stated as "must" elsewhere in the same docs (workflows/basics.mdx:144 — "All Workflow Definition parameters must be serializable"), so the strengthening is defensible. Not substantive.
Match rate: 9/9 = 100% (with the above non-substantive notes).
Check 5 findings
None.
references/java/integrations/jackson-3.mdreferences/integrations.mdwith all five fieldsSKILL.mdeditreferences/java/java.mdai-patterns.mdor siblingNon-blocking consistency observation (not a Check 5 finding): the catalog row in
references/integrations.mdasserts the integration is "wire-compatible with existing Jackson 2 converters" as factual prose, while the reference file at line 13 flags exactly that claim as<!-- VERIFY: … planning-doc claim, not yet documented in ../documentation/ -->. The catalog row could be softened (e.g. "intended to be wire-compatible") to stay consistent with the reference file's own hedging. This is a tone/consistency note, not a layout finding.Statistics
Notes on authoring strategy (informational, not a finding)
The skill file deliberately documents a topic the docs clone does not yet cover. Rather than fabricate the Jackson 3 API surface, the author:
<!-- VERIFY: -->.Jackson3JsonPayloadConverteras if it existed").converters-and-encryption.mdx) for the future Jackson 3 section.This is exactly the anti-fabrication pattern the four-check protocol is designed to reward, and the file passes every check cleanly. GO.