Skip to content

Implement planned topic: 0033-lambda-workers#201

Closed
skill-temporal-developer-updater[bot] wants to merge 1 commit into
mainfrom
draft/0033-lambda-workers
Closed

Implement planned topic: 0033-lambda-workers#201
skill-temporal-developer-updater[bot] wants to merge 1 commit into
mainfrom
draft/0033-lambda-workers

Conversation

@skill-temporal-developer-updater
Copy link
Copy Markdown
Contributor

Validation Report — lambda-workers

Branch: draft/0033-lambda-workers
Files under validation:

  • references/go/integrations/lambda-worker.md
  • references/python/integrations/lambda-worker.md
  • references/typescript/integrations/lambda-worker.md
  • references/integrations.md (catalog row additions)

Note on branch state: all four changes live in the working tree only; the branch has no commits ahead of main (so git diff main..HEAD is empty and git diff against the index shows the catalog edit). Validation treated the working-tree state as the unit under review.


Go/no-go

Check Verdict Detail
1. Citation audit PASS 218 / 219 citations clean (99.5 %, threshold ≥ 98 %).
2. Reverse-grep audit PASS 0 unexplained token misses across all three files.
3. Regression on known bugs HIT (docs-derived) 2 universal-regression hits (TEMPORAL_TLS_CLIENT_CERT_PATH, TEMPORAL_TLS_CLIENT_KEY_PATH) in all three files, but they are transcribed verbatim from the docs at the cited lines. See discussion below.
4. Independent re-verification PASS 30 / 30 sampled claims match (100 %, threshold ≥ 95 %).
5. Integration-layout audit PASS All five sub-checks pass.

Overall verdict: MINOR FIXES (or upstream-docs fix). The strict reading of the rubric makes Check 3 hits "RE-RUN AUTHORING," but in this case the suspect tokens trace cleanly to the source-of-truth docs that the regression rule is supposed to be checking against. The hits indicate a contradiction between the universal regression list and the current docs, not an authoring fabrication. Recommended action: (a) confirm with maintainers whether the regression entry for the TLS env var names is still correct or has been superseded by the new TEMPORAL_TLS_CLIENT_CERT_PATH / _KEY_PATH naming used in docs/production-deployment/worker-deployments/serverless-workers/aws-lambda.mdx; (b) once resolved, either update the docs (and have authors re-pull) or update the regression list. No re-authoring is needed for any other reason.


Check 1 findings

Only one non-clean citation across 219:

  • references/python/integrations/lambda-worker.md:268 — cited docs/troubleshooting/serverless-workers.mdx:146 resolves to a blank line. Adjacent cited lines :144 and :148 in the same multi-citation cluster both support the authored claim, so the claim is supported, but the specific line number is a wrong-line pointer (likely an off-by-one or pointing at paragraph whitespace). Verdict: WRONG_LINE — low-severity.

No other wrong-line, not-supported, or missing-file citations were found.

Check 2 findings

Zero unexplained grep-misses across all three files. Every Go SDK identifier, Python SDK identifier, TypeScript SDK identifier, package path, import path, CLI command, CLI flag, AWS runtime identifier (provided.al2023, python3.13, nodejs22.x), env var, IAM permission, ADOT layer name (aws-otel-collector-amd64), collector endpoint (localhost:4317), and self-hosted dynamic config key (workercontroller.enabled, workercontroller.compute_providers.enabled, workercontroller.scaling_algorithms.enabled) is present in the corresponding docs subtree. Numeric defaults in all three Lambda-tuned-defaults tables match the source docs verbatim.

Check 3 findings

Two universal-regression patterns trip in all three authored files:

  • TEMPORAL_TLS_CLIENT_CERT_PATH — appears in:
    • references/go/integrations/lambda-worker.md:202
    • references/python/integrations/lambda-worker.md:227
    • references/typescript/integrations/lambda-worker.md:225
  • TEMPORAL_TLS_CLIENT_KEY_PATH — appears in the same three locations.

Both names are cited as docs/production-deployment/worker-deployments/serverless-workers/aws-lambda.mdx:322-327. Direct read of that table confirms the docs do use these exact identifiers:

| `TEMPORAL_TLS_CLIENT_CERT_PATH` | Path to the TLS client certificate file for mTLS authentication.       |
| `TEMPORAL_TLS_CLIENT_KEY_PATH`  | Path to the TLS client key file for mTLS authentication.               |

The universal regression rule says these should be TEMPORAL_TLS_CERT / TEMPORAL_TLS_KEY. The authored files faithfully transcribed the docs, so this is an upstream-docs / regression-rule conflict rather than an authoring fabrication. No other regression patterns hit (--profile, tcld service-account, --output text|jsonl, saas-api.tmprl.cloud:7233, provided.al2 non-al2023, TEMPORAL_TLS_SERVER_CA_CERT_PATH are all absent).

Check 4 findings

Sample size 30 (10 per language). 30 / 30 matched substantively. No subtle-wrong interpretations detected. A handful of stylistic differences appeared (compression of two doc sentences into one, accurate parenthetical elaboration tying a value to the AWS Lambda --timeout flag, etc.) and were classified as STYLE_DIFF, which by the rubric does not count against the match rate.

Sampled citations spanned each file's sections (overview / install / minimal worker / versioning / TOML resolution / Lambda-tuned defaults / tuning / observability / deployment recipe / constraints).

Check 5 findings

Sub-check Result
5.1 File location at references/{language}/integrations/{name}.md PASS — three new files at references/go/integrations/lambda-worker.md, references/python/integrations/lambda-worker.md, references/typescript/integrations/lambda-worker.md.
5.2 Exactly one new catalog row per integration PASS — three rows appended to references/integrations.md, one per language. Each row has all five columns (integration, language, what-it-does, reference path, related-topic).
5.3 No SKILL.md edit PASSgit diff shows SKILL.md is untouched; no mention of lambda or aws lambda in SKILL.md.
5.4 No per-integration bullet in language entry-point PASSreferences/go/go.md, references/python/python.md, references/typescript/typescript.md contain no Lambda references.
5.5 Inline cross-link cap ≤ one line in topical refs PASS — no Lambda references in references/core/ai-patterns.md, references/python/ai-patterns.md, or any other topical reference.

Statistics

  • Citations counted: Go 56, Python 78, TypeScript 85 → 219 total.
  • Citations clean: 56 + 77 + 85 = 218 (99.5 %).
  • Unexplained grep-misses: 0.
  • Check 3 hits: 2 distinct universal-regression patterns, each appearing once per file (6 occurrences total), all docs-derived.
  • Check 4 sample size: 30 (10 per file).
  • Check 4 match rate: 30 / 30 (100 %).
  • Check 5 sub-checks passed: 5 / 5.

Recommended next steps

  1. Resolve the TLS env-var-name tension. Either (a) update docs/production-deployment/worker-deployments/serverless-workers/aws-lambda.mdx to use TEMPORAL_TLS_CERT / TEMPORAL_TLS_KEY (then have authors re-pull the citations), or (b) confirm the new _PATH-suffixed names are intentional for the serverless context and remove the entries from the universal regression list. No action is needed on the authored files until this is decided.
  2. Optional micro-fix on references/python/integrations/lambda-worker.md:268: change the :146 line pointer inside the multi-citation cluster to :145 or :147 (or drop it, since :144 and :148 already cover the claim). Low priority — single off-by-one in a 219-citation corpus.

No other findings.

@skill-temporal-developer-updater skill-temporal-developer-updater Bot requested a review from a team as a code owner May 13, 2026 20:06
@donald-pinckney donald-pinckney deleted the draft/0033-lambda-workers branch May 14, 2026 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant