Implement planned topic: 0033-lambda-workers#201
Closed
skill-temporal-developer-updater[bot] wants to merge 1 commit into
Closed
Implement planned topic: 0033-lambda-workers#201skill-temporal-developer-updater[bot] wants to merge 1 commit into
skill-temporal-developer-updater[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validation Report —
lambda-workersBranch:
draft/0033-lambda-workersFiles under validation:
references/go/integrations/lambda-worker.mdreferences/python/integrations/lambda-worker.mdreferences/typescript/integrations/lambda-worker.mdreferences/integrations.md(catalog row additions)Note on branch state: all four changes live in the working tree only; the branch has no commits ahead of
main(sogit diff main..HEADis empty andgit diffagainst the index shows the catalog edit). Validation treated the working-tree state as the unit under review.Go/no-go
TEMPORAL_TLS_CLIENT_CERT_PATH,TEMPORAL_TLS_CLIENT_KEY_PATH) in all three files, but they are transcribed verbatim from the docs at the cited lines. See discussion below.Overall verdict: MINOR FIXES (or upstream-docs fix). The strict reading of the rubric makes Check 3 hits "RE-RUN AUTHORING," but in this case the suspect tokens trace cleanly to the source-of-truth docs that the regression rule is supposed to be checking against. The hits indicate a contradiction between the universal regression list and the current docs, not an authoring fabrication. Recommended action: (a) confirm with maintainers whether the regression entry for the TLS env var names is still correct or has been superseded by the new
TEMPORAL_TLS_CLIENT_CERT_PATH/_KEY_PATHnaming used indocs/production-deployment/worker-deployments/serverless-workers/aws-lambda.mdx; (b) once resolved, either update the docs (and have authors re-pull) or update the regression list. No re-authoring is needed for any other reason.Check 1 findings
Only one non-clean citation across 219:
references/python/integrations/lambda-worker.md:268— citeddocs/troubleshooting/serverless-workers.mdx:146resolves to a blank line. Adjacent cited lines:144and:148in the same multi-citation cluster both support the authored claim, so the claim is supported, but the specific line number is a wrong-line pointer (likely an off-by-one or pointing at paragraph whitespace). Verdict: WRONG_LINE — low-severity.No other wrong-line, not-supported, or missing-file citations were found.
Check 2 findings
Zero unexplained grep-misses across all three files. Every Go SDK identifier, Python SDK identifier, TypeScript SDK identifier, package path, import path, CLI command, CLI flag, AWS runtime identifier (
provided.al2023,python3.13,nodejs22.x), env var, IAM permission, ADOT layer name (aws-otel-collector-amd64), collector endpoint (localhost:4317), and self-hosted dynamic config key (workercontroller.enabled,workercontroller.compute_providers.enabled,workercontroller.scaling_algorithms.enabled) is present in the corresponding docs subtree. Numeric defaults in all three Lambda-tuned-defaults tables match the source docs verbatim.Check 3 findings
Two universal-regression patterns trip in all three authored files:
TEMPORAL_TLS_CLIENT_CERT_PATH— appears in:references/go/integrations/lambda-worker.md:202references/python/integrations/lambda-worker.md:227references/typescript/integrations/lambda-worker.md:225TEMPORAL_TLS_CLIENT_KEY_PATH— appears in the same three locations.Both names are cited as
docs/production-deployment/worker-deployments/serverless-workers/aws-lambda.mdx:322-327. Direct read of that table confirms the docs do use these exact identifiers:The universal regression rule says these should be
TEMPORAL_TLS_CERT/TEMPORAL_TLS_KEY. The authored files faithfully transcribed the docs, so this is an upstream-docs / regression-rule conflict rather than an authoring fabrication. No other regression patterns hit (--profile,tcld service-account,--output text|jsonl,saas-api.tmprl.cloud:7233,provided.al2non-al2023,TEMPORAL_TLS_SERVER_CA_CERT_PATHare all absent).Check 4 findings
Sample size 30 (10 per language). 30 / 30 matched substantively. No subtle-wrong interpretations detected. A handful of stylistic differences appeared (compression of two doc sentences into one, accurate parenthetical elaboration tying a value to the AWS Lambda
--timeoutflag, etc.) and were classified as STYLE_DIFF, which by the rubric does not count against the match rate.Sampled citations spanned each file's sections (overview / install / minimal worker / versioning / TOML resolution / Lambda-tuned defaults / tuning / observability / deployment recipe / constraints).
Check 5 findings
references/{language}/integrations/{name}.mdreferences/go/integrations/lambda-worker.md,references/python/integrations/lambda-worker.md,references/typescript/integrations/lambda-worker.md.references/integrations.md, one per language. Each row has all five columns (integration, language, what-it-does, reference path, related-topic).SKILL.mdeditgit diffshowsSKILL.mdis untouched; no mention oflambdaoraws lambdainSKILL.md.references/go/go.md,references/python/python.md,references/typescript/typescript.mdcontain no Lambda references.references/core/ai-patterns.md,references/python/ai-patterns.md, or any other topical reference.Statistics
Recommended next steps
docs/production-deployment/worker-deployments/serverless-workers/aws-lambda.mdxto useTEMPORAL_TLS_CERT/TEMPORAL_TLS_KEY(then have authors re-pull the citations), or (b) confirm the new_PATH-suffixed names are intentional for the serverless context and remove the entries from the universal regression list. No action is needed on the authored files until this is decided.references/python/integrations/lambda-worker.md:268: change the:146line pointer inside the multi-citation cluster to:145or:147(or drop it, since:144and:148already cover the claim). Low priority — single off-by-one in a 219-citation corpus.No other findings.