fix(iaas): send snapshot policy ttl as string - #110
Open
janhaitjema wants to merge 1 commit into
Open
Conversation
`Ttl` is a `time.Duration` on the create and update requests, which
`encoding/json` serialises as nanoseconds. The API expects a duration string,
so every create and update fails with:
json: cannot unmarshal number into Go struct field .ttl of type string
Adds `MarshalJSON` to both request types emitting `"168h0m0s"`. The field stays
a `time.Duration`, so callers need no change. Reads are untouched: the API
returns a number there and consumers already call `Ttl.String()`.
Verified by building the Terraform provider against this branch and creating a
policy against the live API. Same config fails on v0.35.3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ttlis atime.Durationon the create and update requests, whichencoding/jsonserialises as nanoseconds. The API expects a duration string, so every create and update fails with:Adds
MarshalJSONto both request types emitting"168h0m0s". The field stays atime.Duration, so callers need no change. Reads are untouched: the API returns a number there and consumers already callTtl.String().Verified by building the Terraform provider against this branch and creating a policy against the live API. Same config fails on v0.35.3.