Auto: sync versions [release-v1.44] - #5229
Open
github-actions[bot] wants to merge 1 commit into
Open
Conversation
marvin-tigera
approved these changes
Aug 20, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Automated sync of Calico IPPool CRD definitions into the operator’s release-v1.44 branch (via make gen-versions), updating the imported CRD YAML used by the operator for versioned CRD distribution.
Changes:
- Tightens the documented blockSize range for IPPools (IPv4: 20–32, IPv6: 116–128).
- Adds additional
x-kubernetes-validationsrules for IPPool CIDR masking, link-local overlap prevention, blockSize bounds, and minimum pool size constraints.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pkg/imports/crds/calico/v3.projectcalico.org/projectcalico.org_ippools.yaml | Updates IPPool schema docs and adds CEL validations for CIDR and blockSize constraints. |
| pkg/imports/crds/calico/v1.crd.projectcalico.org/crd.projectcalico.org_ippools.yaml | Mirrors the same IPPool schema doc update and CEL validations in the v1.crd CRD import. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
94
to
+97
| description: |- | ||
| The block size to use for IP address assignments from this pool. Defaults to 26 for IPv4 and 122 for IPv6. | ||
| The block size must be between 0 and 32 for IPv4 and between 0 and 128 for IPv6. It must also be smaller than | ||
| or equal to the size of the pool CIDR. | ||
| The block size must be between 20 and 32 for IPv4 and between 116 and 128 for IPv6. It must also be smaller | ||
| than or equal to the size of the pool CIDR. |
Comment on lines
69
to
+72
| description: |- | ||
| The block size to use for IP address assignments from this pool. Defaults to 26 for IPv4 and 122 for IPv6. | ||
| The block size must be between 0 and 32 for IPv4 and between 0 and 128 for IPv6. It must also be smaller than | ||
| or equal to the size of the pool CIDR. | ||
| The block size must be between 20 and 32 for IPv4 and between 116 and 128 for IPv6. It must also be smaller | ||
| than or equal to the size of the pool CIDR. |
github-actions
Bot
force-pushed
the
auto-sync-versions-release-v1.44
branch
from
August 21, 2026 18:08
11fa168 to
c881928
Compare
Contributor
|
Removing "merge-when-ready" label due to new commits |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
Suppressed comments (2)
pkg/imports/crds/calico/v3.projectcalico.org/projectcalico.org_ippools.yaml:97
- The blockSize description now states it must be between 20–32 (IPv4) / 116–128 (IPv6), but the schema/validations explicitly allow blockSize=0 (and omitting the field) as a valid way to use the default block size. This makes the CRD documentation misleading.
description: |-
The block size to use for IP address assignments from this pool. Defaults to 26 for IPv4 and 122 for IPv6.
The block size must be between 20 and 32 for IPv4 and between 116 and 128 for IPv6. It must also be smaller
than or equal to the size of the pool CIDR.
pkg/imports/crds/calico/v1.crd.projectcalico.org/crd.projectcalico.org_ippools.yaml:72
- The blockSize description now states it must be between 20–32 (IPv4) / 116–128 (IPv6), but the schema/validations explicitly allow blockSize=0 (and omitting the field) as a valid way to use the default block size. This makes the CRD documentation misleading.
description: |-
The block size to use for IP address assignments from this pool. Defaults to 26 for IPv4 and 122 for IPv6.
The block size must be between 20 and 32 for IPv4 and between 116 and 128 for IPv6. It must also be smaller
than or equal to the size of the pool CIDR.
github-actions
Bot
force-pushed
the
auto-sync-versions-release-v1.44
branch
from
August 24, 2026 23:06
c881928 to
4d1931d
Compare
Contributor
|
Removing "merge-when-ready" label due to new commits |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
Suppressed comments (2)
pkg/imports/crds/calico/v3.projectcalico.org/projectcalico.org_ippools.yaml:97
- The updated description states the blockSize must be between 20-32 (IPv4) / 116-128 (IPv6), but the schema and CEL validation still allow blockSize == 0 (treated as 'use default'). Please document the special-case for 0 to avoid misleading API consumers and clients doing schema-based validation.
description: |-
The block size to use for IP address assignments from this pool. Defaults to 26 for IPv4 and 122 for IPv6.
The block size must be between 20 and 32 for IPv4 and between 116 and 128 for IPv6. It must also be smaller
than or equal to the size of the pool CIDR.
pkg/imports/crds/calico/v1.crd.projectcalico.org/crd.projectcalico.org_ippools.yaml:72
- The updated description states the blockSize must be between 20-32 (IPv4) / 116-128 (IPv6), but the schema and CEL validation still allow blockSize == 0 (treated as 'use default'). Please document the special-case for 0 to avoid misleading API consumers and clients doing schema-based validation.
description: |-
The block size to use for IP address assignments from this pool. Defaults to 26 for IPv4 and 122 for IPv6.
The block size must be between 20 and 32 for IPv4 and between 116 and 128 for IPv6. It must also be smaller
than or equal to the size of the pool CIDR.
github-actions
Bot
force-pushed
the
auto-sync-versions-release-v1.44
branch
from
August 25, 2026 14:16
4d1931d to
db6ba6c
Compare
Contributor
|
Removing "merge-when-ready" label due to new commits |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Suppressed comments (2)
pkg/imports/crds/calico/v3.projectcalico.org/projectcalico.org_ippools.yaml:97
- The
blockSizedescription states it must be between 20–32 (IPv4) / 116–128 (IPv6), but the schema validations allowblockSize == 0(and omission) as a special case. The description should mention that0/unset means “use defaults” to avoid misleading users.
description: |-
The block size to use for IP address assignments from this pool. Defaults to 26 for IPv4 and 122 for IPv6.
The block size must be between 20 and 32 for IPv4 and between 116 and 128 for IPv6. It must also be smaller
than or equal to the size of the pool CIDR.
pkg/imports/crds/calico/v1.crd.projectcalico.org/crd.projectcalico.org_ippools.yaml:72
- The
blockSizedescription says it must be between 20–32 (IPv4) / 116–128 (IPv6), but the CRD validations allowblockSize == 0(and omission) as a valid way to use defaults. The description should reflect that to avoid confusion.
description: |-
The block size to use for IP address assignments from this pool. Defaults to 26 for IPv4 and 122 for IPv6.
The block size must be between 20 and 32 for IPv4 and between 116 and 128 for IPv6. It must also be smaller
than or equal to the size of the pool CIDR.
Comment on lines
+1875
to
+1877
| This field must be kept consistent with BGPConfiguration.ProgramClusterRoutes, which | ||
| makes the same choice from BIRD's side. If both Felix and BIRD are enabled for the same | ||
| kind of IP Pool they will fight over the routes; if neither is, there will be no cluster |
Comment on lines
+222
to
+224
| has ipipMode and vxlanMode both Never. | ||
|
|
||
| - Disabled: BIRD programs no cluster routes. |
Comment on lines
+1876
to
+1878
| This field must be kept consistent with BGPConfiguration.ProgramClusterRoutes, which | ||
| makes the same choice from BIRD's side. If both Felix and BIRD are enabled for the same | ||
| kind of IP Pool they will fight over the routes; if neither is, there will be no cluster |
Comment on lines
+227
to
+229
| This field must be kept consistent with FelixConfiguration.ProgramClusterRoutes, which | ||
| makes the same choice from Felix's side. If both Felix and BIRD are enabled for the same | ||
| kind of IP Pool they will fight over the routes; if neither is, there will be no cluster |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated sync of versions and CRDs from Calico and Calico Enterprise into
release-v1.44viamake gen-versions.Triggered by scheduled workflow.