Default ApplicationLayer and ManagementCluster fields in the CRD schema - #5241
Open
caseydavenport wants to merge 1 commit into
Open
Default ApplicationLayer and ManagementCluster fields in the CRD schema#5241caseydavenport wants to merge 1 commit into
caseydavenport wants to merge 1 commit into
Conversation
The API server applies these defaults, so the operator no longer takes field ownership by writing them into the spec.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-on to #5203. The other CRs have the same problem: the operator defaults a field, patches it back, and becomes the field manager, so a server-side apply from Helm or Argo conflicts. Installation had to record its defaults in the status because its defaulting needs cluster state and because of the overlay, and neither applies here, so these are plain CRD schema defaults.
This covers ApplicationLayer and ManagementCluster, the two CRs where schema defaults replace the write-back completely:
One behavior change, in ApplicationLayer: the L7 log interval and requests-per-interval were only defaulted when log collection was enabled, and they now always default. Nothing renders them unless log collection is on, so the only difference is the two fields appearing in the spec.
Increments left for follow-ups, all for a reason rather than for size:
Each of those keeps its write-back until the whole CR can drop it, since a schema default that doesn't let us remove the patch doesn't release ownership.
Related: #5102
Release Note
For PR author
make gen-filesmake gen-versions