Resolve the CSR init image without branching on the variant - #5256
Open
caseydavenport wants to merge 1 commit into
Open
Resolve the CSR init image without branching on the variant#5256caseydavenport wants to merge 1 commit into
caseydavenport wants to merge 1 commit into
Conversation
The Enterprise-only renders name the Enterprise image, and the certificate manager is the only caller that picks one at runtime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Image selection for the CSR init container went through a shared helper that asked which variant is installed. Six of its seven callers are Enterprise-only renders (dex, elasticsearch, kibana, linseed, dashboards, esgateway), so they name the Enterprise image directly and the helper collapses into the certificate manager, the only caller left that picks at runtime. Those six were already getting the Enterprise image out of the helper, so no test expectations move.
Related: CORE-13398