fix(daemon): stop cleanly on Windows - #844
Open
y4ho0 wants to merge 1 commit into
Open
Conversation
y4ho0
marked this pull request as ready for review
August 12, 2026 18:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
Closes #843
What & why
crg-daemon stoppolled process state withos.kill(pid, 0)and escalated withsignal.SIGKILL. Both assumptions are POSIX-specific: on Windows the liveness probe does not reliably report an exited process, andSIGKILLis unavailable.The resulting
AttributeErroralso skipped PID cleanup and preventedcrg-daemon restartfrom starting the daemon again.This change:
pid_alive()helper while waiting for shutdownSIGKILLwhen available and falls back toSIGTERMon platforms without itfinallyblock so a failed forced stop cannot leave stale stateHow it was tested
AI assistance
OpenAI Codex was used for repository inspection, implementation and test drafting, local verification, and review of the resulting diff.
Checklist