Update Node.js version to fix CI - #32
Merged
Merged
Conversation
``` error mktemp@2.0.2: The engine "node" is incompatible with this module. Expected version "20 || 22 || 24". Got "18.20.8" error Found incompatible module. ``` https://github.com/tricknotes/ember-cli-rails-assets/actions/runs/24065729896/job/70191312530?pr=31#step:7:50
`ember-cli-output` tracks the output of `ember new`, and since ember-cli 6.8 that output is built by Vite instead of Broccoli. A Vite build breaks the setup in two ways: - `ember-cli-rails-addon` sets `storeConfigInMeta = false`, which makes it contribute content-for 'config-module'. Embroider rejects that. - Its CSRF initializer does `import Ember from 'ember'`, which no longer resolves. Neither is fixable from this repository, and the built assets would not be laid out the way `EmberCli::Assets::Lookup` expects anyway. Pin the clone to v6.7.2, the last release built by Broccoli, so the suite keeps exercising the build layout this gem supports. Co-Authored-By: Claude <noreply@anthropic.com>
rspec-rails 8.0.4 cannot load feature specs against Rails 8.2.0.alpha:
`ActionDispatch::Routing::UrlFor` now freezes `default_url_options`, and
`RSpec::Rails::FeatureExampleGroup` mutates it while being included.
FrozenError:
can't modify frozen Hash: {}
# rspec-rails-8.0.4/lib/rspec/rails/example/feature_example_group.rb:19
That has to be fixed in rspec-rails, and Rails main will keep breaking in
new ways regardless, so run the job for information only.
Co-Authored-By: Claude <noreply@anthropic.com>
Adding `experimental` to the matrix renamed the job to `build (3.4, main, true)`. Set the name explicitly so it stays `build (3.4, main)`. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix the following error on CI.
https://github.com/tricknotes/ember-cli-rails-assets/actions/runs/24065729896/job/70191312530?pr=31#step:7:50