Raise a descriptive error for stylesheet tags on Vite-based apps - #34
Merged
Conversation
`include_ember_stylesheet_tags` only supports classic (Broccoli-based) applications: its lookup resolves stylesheets against `dist/assets/`, which cannot resolve the `/@embroider/virtual/*` stylesheet references a Vite build leaves in `index.html`. Calling it for a Vite-based application therefore failed with a confusing "Failed to find assets matching" error. It is also unnecessary there: since 0.8.0, `include_ember_script_tags` emits everything a Vite-based application needs to boot, stylesheet tags included. Raise `EmberCli::Assets::NotSupportedError` with a message that points at `include_ember_script_tags` instead, and document how the helpers apply to each build system in the README. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
include_ember_stylesheet_tagsonly supports classic (Broccoli-based) applications: its lookup resolves stylesheets againstdist/assets/, which cannot resolve the/@embroider/virtual/*stylesheet references a Vite build leaves inindex.html. Calling it for a Vite-based application therefore failed with a confusing "Failed to find assets matching" error.It is also unnecessary there: since 0.8.0,
include_ember_script_tagsemits everything a Vite-based application needs to boot, stylesheet tags included.Raise
EmberCli::Assets::NotSupportedErrorwith a message that points atinclude_ember_script_tagsinstead, and document how the helpers apply to each build system in the README.