Restrict mount/pivot_root/userns to nsjail via AppArmor profile transition - #371
Draft
mertbozfakioglu wants to merge 3 commits into
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
3 tasks
Contributor
|
| Filename | Overview |
|---|---|
| charts/retool/templates/apparmor_nsjail_configmap.yaml | Introduces the scoped nsjail child profile, but removes an installer-required ConfigMap key and does not update integration tests for the new policy contract. |
Reviews (1): Last reviewed commit: "Restrict mount/pivot_root/userns to nsja..." | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
…ition Replace the broad retool-executor AppArmor profile (which granted mount, pivot_root, umount, userns to the entire container) with a two-profile design using a mandatory exec transition (px): - retool-executor: container's main profile — network, capability, file only. No mount/pivot_root/userns. Node.js cannot call these directly. - retool-executor//nsjail: child profile entered only when exec'ing /usr/bin/nsjail. Adds mount, pivot_root, umount, userns. The old standalone usr.bin.nsjail profile (flags=unconfined) is removed — nsjail now runs under the scoped child profile with the same deny rules as the parent. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Remove usr.bin.nsjail copy/load from DaemonSet — the child profile retool-executor//nsjail is defined inside the retool-executor entry and loaded by apparmor_parser together with it. - Update test to check for retool-executor//nsjail in kernel instead of /usr/bin/nsjail. - Flip the unshare assertion: under the parent profile, unshare --user --mount must now FAIL (mount/userns restricted to nsjail via px). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
mertbozfakioglu
force-pushed
the
mertbozfakioglu/apparmor-nsjail-profile-transition
branch
from
September 11, 2026 17:51
466d100 to
d179275
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
retool-executorAppArmor profile with a two-profile design using a mandatory exec transition (px)retool-executor) no longer grantsmount,pivot_root,umount, oruserns— Node.js and all other processes in the container cannot call these syscalls/usr/bin/nsjailgets these permissions, via automatic AppArmor profile transition toretool-executor//nsjailon execusr.bin.nsjailprofile (which wasflags=(unconfined), effectively unrestricted)Before
After
Stacked on
Test plan
mount()syscall from Node.js is denied by AppArmor🤖 Generated with Claude Code