Skip to content

Add delete confirmation modal in ImageManager #940

Description

@jumbosushi

What behavior were you expecting?

When I click delete button in ImangeManager from ArticleEditors, I expect to see delete confirmation modal.

ImageManager delete button in ArticleEditor
article-error

/images/ delete confirmation modal example
image

What actually happened?

No delete confirmation modal popped up. This could lead to images being deleted accidentally

Steps to reproduce

(Try this in your local server NOT on prod)
0. Go to /admin/articles/new

  1. Click on Featured Image Tab
  2. Click "Select Image" to open ImageManager
  3. Try to delete any image

What was your environment like?

Google Chrome 74.0.3729.157 on Ubuntu 16.04 LTS

Getting Started

Look at how <ConfirmButtom/> (code link) is being used in <ListItemToolbar/> component (code link)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions