type-pointer fails when called with class#2
Open
orb wants to merge 1 commit intouncomplicate:masterfrom
Open
Conversation
Author
|
Here's` an example before: And here is the output with this fix: |
Author
|
For reference, this is how it's affecting map-vector. Before: After: |
In neanderthal, `map-vector` calls this function with a java class such as Byte/TYPE, however the case function here effectively is comparing the class type passed in with (effectively) `(symbol "BYTE/Type")` and returns null, causing map-vector to fail in all cases for me. Adding the cond at the end, a pattern I copied from similar comparisons in neanderthal, fixes this so that `map-vector` works as intended. I left the symbol comparisons in because maybe there is actually a use case I'm not aware of in which that is desirable, but I have to imagine we would want to remove them.
Member
|
Thank you. This was already on my list and will be included in the next update in about two weeks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In neanderthal,
map-vectorcalls this function with a java class such as Byte/TYPE, however the case function here effectively is comparing the class type passed in with (effectively)(symbol "BYTE/Type")and returns null, causing map-vector to fail in all cases for me.Adding the cond at the end, a pattern I copied from similar comparisons in neanderthal, fixes this so that
map-vectorworks as intended.I left the symbol comparisons in because maybe there is actually a use case I'm not aware of in which that is desirable, but I have to imagine we would want to remove them.